Implement the feedbackPrivate API.

chrome/common/extensions/api/feedback_private.idl

Index: chrome/common/extensions/api/feedback_private.idl
diff --git a/chrome/common/extensions/api/feedback_private.idl b/chrome/common/extensions/api/feedback_private.idl
new file mode 100644
index 0000000000000000000000000000000000000000..ecde48fd9f73959aef6c6a2dcaf0c471beb45f60
--- /dev/null
+++ b/chrome/common/extensions/api/feedback_private.idl
@@ -0,0 +1,79 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+namespace feedbackPrivate {
+
+  dictionary AttachedFile {
+    DOMString name;
+    [instanceOf=Blob] object data;
+  };
+
+  dictionary SystemInformation {
+    DOMString key;
+    DOMString value;
+  };
+
+  dictionary FeedbackInfo {
+    // File to attach to the feedback report.
+    AttachedFile? attachedFile;
+
+    // An optional tag to label what type this feedback is.
+    DOMString? categoryTag;
+
+    // The feedback text describing the user issue.
+    DOMString description;
+
+    // The e-mail of the user that initiated this feedback.
+    DOMString? email;
+
+    // The URL of the page that this issue was being experienced on.
+    DOMString? pageUrl;
+
+    // Optional product ID to override the Chrome [OS] product id that is
+    // usually passed to the feedback server.
+    DOMString? productId;
+
+    // Screenshot to send with this feedback. This need to be a base64 encoded

[asargent_no_longer_on_chrome, 2013/06/17 19:32:40]

typo: "This need" -> "This needs"

Also, is the "base64 encoded" part of this comment still accurate? If we're
dealing with a Blob, wouldn't we just pass the raw bytes instead of a
base64-encoded string representing the bytes?

[rkc, 2013/06/17 21:48:19]

Ah, old comment, changed.
I had originally started with sending the data as base64 till mpcomplete@
suggested on the API review that I change this to blobs.

Done.

+    // png image.
+    [instanceOf=Blob] object? screenshot;
+
+    // An array of key/value pairs providing system information for this
+    // feedback report.
+    SystemInformation[]? systemInformation;
+
+    // TODO(rkc): Remove these once we have bindings to send blobs to Chrome.
+    // Used internally to store the blob Url after parameter customization.
+    DOMString attachedFileBlobUrl;
+    DOMString screenshotBlobUrl;
+  };
+
+  // Status of the sending of a feedback report.
+  enum Status {success, delayed};
+
+  callback GetUserEmailCallback = void(DOMString email);
+  callback GetSystemInformationCallback =
+      void(SystemInformation[] systemInformation);

[asargent_no_longer_on_chrome, 2013/06/17 19:32:40]

Since this is a private API it's ok for this to be an unstructured list of
key/value pairs, but to graduate to publicly supported it might be nice to see
if we could declare (or at least document) all the values we know will be
present. 

Also note that we have systemInfo.{cpu,memory,display} which provide some system
information. We'll eventually want to make sure to eliminate any duplication in
the information they provide and what you return from getSystemInformation here.
(Perhaps by pushing additional things you need into one or more of the
namespaces in systemInfo.* ?)

[rkc, 2013/06/17 21:48:19]

I'll think about how to integrate this information with systemInfo. Currently
the system information that this API pulls is from a dedicated fetcher where
devs add logs specifically to have them show up in about:system and to go to
feedback reports. So the 'purpose' of those logs is different than those from
systemInfo; but we can try to ensure that we don't gather logs again which are
already available from systemInfo. I'll investigate this further.

+  callback SendFeedbackCallback = void(Status status);
+  callback GetStringsCallback = void(object result);
+
+  interface Functions {
+    // Returns the email of the currently active or logged in user.
+    static void getUserEmail(GetUserEmailCallback callback);
+
+    // Returns the system information dictionary.
+    static void getSystemInformation(GetSystemInformationCallback callback);
+
+    // Sends a feedback report.
+    static void sendFeedback(FeedbackInfo feedback,
+                             SendFeedbackCallback callback);
+  };
+
+  interface Events {
+    // Fired when the a user requests the launch of the feedback UI. We're
+    // using an event for this versus using the override API since we want
+    // to be invoked, but not showing a UI, so the feedback extension can
+    // take a screenshot of the user's desktop.
+    static void onFeedbackRequested(FeedbackInfo feedback);
+  };
+};