Implement the feedbackPrivate API.

chrome/browser/extensions/api/feedback_private/blob_reader.h

Index: chrome/browser/extensions/api/feedback_private/blob_reader.h
diff --git a/chrome/browser/extensions/api/feedback_private/blob_reader.h b/chrome/browser/extensions/api/feedback_private/blob_reader.h
new file mode 100644
index 0000000000000000000000000000000000000000..49dedcef4bfce9e10e328d6bd76e6b57a4a300f1
--- /dev/null
+++ b/chrome/browser/extensions/api/feedback_private/blob_reader.h
@@ -0,0 +1,47 @@
+// Copyright (c) 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef CHROME_BROWSER_EXTENSIONS_API_FEEDBACK_PRIVATE_BLOB_READER_H_

[asargent_no_longer_on_chrome, 2013/06/17 19:32:40]

It seems like this header and the .cc file could live somewhere more general,
like chrome/browser/common/ (or even in content/public/browser/ ). Maybe consult
joi@ ?

[rkc, 2013/06/17 21:48:19]

This is a really basic user of URLFetcher, I almost contemplated putting the
entire class in the feedback_service.cc file itself. I'll speak with joi@ to see
if we can make this use case (read from a URL, dump it to string) a common class
called something more like URLReader? I'll start a separate CL to move this
class once I've spoken to him.

[asargent_no_longer_on_chrome, 2013/06/17 22:12:58]

Good point. Is this even used from more than one file? If not, it could make
sense to move into an anonymous namespace in the .cc file. Anyhow, waiting to
see what Joi thinks and potentially doing a follow-up CL sounds fine to me. 

[Jói, 2013/06/18 10:29:08]

I would recommend following the principle of narrowest scope here; if this is
used only by one file, you can move it in to the anonymous namespace in the .cc
file using it.  If it is used by more than one, then move it to whatever the
narrowest common scope for those is (e.g. possibly
chrome/browser/extensions/api).  Only if it is intended to be reused by multiple
subsystems and such reuse is going to occur in the near foreseeable future,
should it be moved to somewhere "common" like its own component (under
//components) or some such.  Also, FYI, //chrome/browser/common is gone, or at
least going, as part of a change I reviewed recently.

+#define CHROME_BROWSER_EXTENSIONS_API_FEEDBACK_PRIVATE_BLOB_READER_H_
+
+#include <string>
+
+#include "base/callback.h"
+#include "base/memory/scoped_ptr.h"
+#include "googleurl/src/gurl.h"
+#include "net/base/io_buffer.h"
+#include "net/url_request/url_fetcher_delegate.h"
+#include "net/url_request/url_request.h"
+
+class Profile;
+namespace net {
+class URLFetcher;
+}
+
+class BlobReader : public net::URLFetcherDelegate {
+ public:
+  typedef base::Callback<void(scoped_ptr<std::string> blob_data)>
+      BlobReadCallback;
+
+  BlobReader(Profile* profile,
+             const GURL& blob_url,
+             BlobReadCallback callback);
+  virtual ~BlobReader();
+
+  void Start();
+
+ private:
+  // Overridden from net::URLFetcherDelegate.
+  virtual void OnURLFetchComplete(const net::URLFetcher* source) OVERRIDE;
+
+  BlobReadCallback callback_;
+  net::URLFetcher* fetcher_;
+  Profile* profile_;

[asargent_no_longer_on_chrome, 2013/06/17 19:32:40]

nit: I don't see you actually using |profile_| anywhere in the .cc file - can
you remove the need to pass one in? (That might allow you to have this class
live in content/public/browser/)

[rkc, 2013/06/17 21:48:19]

I don't need to save the profile (hence removing this from here) but I do need
to use it in the .cc file (line 22:
fetcher_->SetRequestContext(profile->GetRequestContext());)

Also removed the unused weak_ptr_factory_.

Done.

[asargent_no_longer_on_chrome, 2013/06/17 22:12:58]

Oops, I missed that (I searched for "profile_" but not just "profile"). You
might consider just passing in the RequestContextGetter instead of the Profile. 

+
+  base::WeakPtrFactory<BlobReader> weak_ptr_factory_;
+
+  DISALLOW_COPY_AND_ASSIGN(BlobReader);
+};
+
+#endif  // CHROME_BROWSER_EXTENSIONS_API_FEEDBACK_PRIVATE_BLOB_READER_H_