Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(354)

Unified Diff: content/renderer/render_widget.cc

Issue 1711083002: [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebased Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_widget.cc
diff --git a/content/renderer/render_widget.cc b/content/renderer/render_widget.cc
index 9709d2e7b9312526056925a8eae95a22aca45457..3f9d45d624fd1a7b2d000caaf6cef37e85795554 100644
--- a/content/renderer/render_widget.cc
+++ b/content/renderer/render_widget.cc
@@ -567,13 +567,7 @@ void RenderWidget::OnResize(const ResizeParams& params) {
return;
}
- bool orientation_changed =
- screen_info_.orientationAngle != params.screen_info.orientationAngle;
-
Resize(params);
-
- if (orientation_changed)
- OnOrientationChange();
}
void RenderWidget::OnEnableDeviceEmulation(
@@ -1060,6 +1054,10 @@ void RenderWidget::Redraw() {
}
void RenderWidget::Resize(const ResizeParams& params) {
+ bool orientation_changed =
+ screen_info_.orientationAngle != params.screen_info.orientationAngle ||
+ screen_info_.orientationType != params.screen_info.orientationType;
+
screen_info_ = params.screen_info;
SetDeviceScaleFactor(screen_info_.deviceScaleFactor);
@@ -1129,6 +1127,9 @@ void RenderWidget::Resize(const ResizeParams& params) {
if (fullscreen_change)
DidToggleFullscreen();
+ if (orientation_changed)
+ OnOrientationChange();
+
// If a resize ack is requested and it isn't set-up, then no more resizes will
// come in and in general things will go wrong.
DCHECK(!params.needs_resize_ack || next_paint_is_resize_ack());

Powered by Google App Engine
This is Rietveld 408576698