components/test_runner/web_test_proxy.cc - Issue 1711083002: [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/test_runner/web_test_proxy.cc

Issue 1711083002: [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebased Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « components/test_runner/mock_screen_orientation_client.cc ('k') | content/browser/devtools/protocol/devtools_protocol_handler_generator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/test_runner/web_test_proxy.cc

diff --git a/components/test_runner/web_test_proxy.cc b/components/test_runner/web_test_proxy.cc

index 9a6d1f8c1972758929b2e874d3f2d4a12d53b32c..0941d7a7a195bdbc9166e6b099ac91b4f4126f82 100644

--- a/components/test_runner/web_test_proxy.cc

+++ b/components/test_runner/web_test_proxy.cc

@@ -592,7 +592,7 @@ void WebTestProxyBase::LayoutAndPaintAsyncThen(const base::Closure& callback) {

void WebTestProxyBase::GetScreenOrientationForTesting(

blink::WebScreenInfo& screen_info) {

- if (!screen_orientation_client_)

+ if (!screen_orientation_client_ || !screen_orientation_client_->is_active())

return;

// Override screen orientation information with mock data.

screen_info.orientationType =