Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(391)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1711083002: [DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. (Closed)

Created:
4 years, 10 months ago by dgozman
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, pfeldman
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, caseq+blink_chromium.org, mlamouri+watch-test-runner_chromium.org, pfeldman+blink_chromium.org, mlamouri+watch-screen-orientation_chromium.org, jam, mlamouri+watch-blink_chromium.org, lushnikov+blink_chromium.org, blink-reviews, dglazkov+blink, darin-cc_chromium.org, pfeldman, devtools-reviews_chromium.org, mkwst+moarreviews-renderer_chromium.org, apavlov+blink_chromium.org, sergeyv+blink_chromium.org, blink-reviews-api_chromium.org, jochen+watch_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[DevTools] Move screen orientation override to RenderWidgetScreenMetricsEmulator. This unifies screen orientation with the rest of screen emulation and covers window.orientation API. BUG=585185 Committed: https://crrev.com/c7185a793efbeaa40e0d20d9d953bc1e2c32f5d1 Cr-Commit-Position: refs/heads/master@{#376822}

Patch Set 1 #

Patch Set 2 : missing file #

Patch Set 3 : typo #

Patch Set 4 : fix compile on win #

Patch Set 5 : rebased #

Unified diffs Side-by-side diffs Delta from patch set Stats (+181 lines, -304 lines) Patch
M components/test_runner/mock_screen_orientation_client.h View 2 chunks +2 lines, -0 lines 0 comments Download
M components/test_runner/mock_screen_orientation_client.cc View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M components/test_runner/web_test_proxy.cc View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M content/browser/devtools/protocol/devtools_protocol_handler_generator.py View 1 2 3 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/devtools/protocol/emulation_handler.h View 1 chunk +14 lines, -12 lines 0 comments Download
M content/browser/devtools/protocol/emulation_handler.cc View 4 chunks +42 lines, -1 line 0 comments Download
M content/common/view_messages.h View 1 chunk +2 lines, -0 lines 0 comments Download
M content/renderer/devtools/render_widget_screen_metrics_emulator.cc View 1 chunk +8 lines, -0 lines 0 comments Download
M content/renderer/render_widget.cc View 1 2 3 chunks +7 lines, -6 lines 0 comments Download
M third_party/WebKit/LayoutTests/http/tests/inspector/inspector-test.js View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/LayoutTests/inspector/screen-orientation-override.html View 3 chunks +37 lines, -19 lines 0 comments Download
M third_party/WebKit/LayoutTests/inspector/screen-orientation-override-expected.txt View 2 chunks +8 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/devtools/front_end/emulation/DeviceModeModel.js View 1 2 3 4 7 chunks +16 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/devtools/protocol.json View 1 2 3 4 4 chunks +15 lines, -28 lines 0 comments Download
M third_party/WebKit/Source/modules/modules.gypi View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.h View 3 chunks +0 lines, -9 lines 0 comments Download
M third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationController.cpp View 5 chunks +5 lines, -31 lines 0 comments Download
D third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.h View 1 chunk +0 lines, -43 lines 0 comments Download
D third_party/WebKit/Source/modules/screen_orientation/ScreenOrientationInspectorAgent.cpp View 1 1 chunk +0 lines, -112 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.h View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/web/DevToolsEmulator.cpp View 3 chunks +4 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/web/WebDevToolsAgentImpl.cpp View 2 chunks +0 lines, -3 lines 0 comments Download
M third_party/WebKit/public/web/WebDeviceEmulationParams.h View 2 chunks +14 lines, -2 lines 0 comments Download

Messages

Total messages: 24 (10 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711083002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711083002/20001
4 years, 10 months ago (2016-02-18 20:15:47 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: cast_shell_linux on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/cast_shell_linux/builds/117936)
4 years, 10 months ago (2016-02-18 20:41:49 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711083002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711083002/40001
4 years, 10 months ago (2016-02-18 21:52:44 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_chromium_gn_compile_rel/builds/24052)
4 years, 10 months ago (2016-02-18 22:14:58 UTC) #8
dgozman
Could you please take a look? Pavel - at the whole patch. Tom - at ...
4 years, 10 months ago (2016-02-19 00:42:35 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711083002/60001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711083002/60001
4 years, 10 months ago (2016-02-19 03:55:56 UTC) #12
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/24054) android_chromium_gn_compile_dbg on ...
4 years, 10 months ago (2016-02-19 04:02:05 UTC) #14
Tom Sepez
view_messages LGTM.
4 years, 10 months ago (2016-02-19 16:43:06 UTC) #15
pfeldman
lgtm
4 years, 10 months ago (2016-02-22 19:47:40 UTC) #16
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1711083002/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1711083002/80001
4 years, 10 months ago (2016-02-22 19:55:02 UTC) #19
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 10 months ago (2016-02-22 22:08:43 UTC) #20
commit-bot: I haz the power
Patchset 5 (id:??) landed as https://crrev.com/c7185a793efbeaa40e0d20d9d953bc1e2c32f5d1 Cr-Commit-Position: refs/heads/master@{#376822}
4 years, 10 months ago (2016-02-22 22:09:32 UTC) #22
engedy
A revert of this CL (patchset #5 id:80001) has been created in https://codereview.chromium.org/1723663005/ by engedy@chromium.org. ...
4 years, 10 months ago (2016-02-23 14:02:57 UTC) #23
shrike
4 years, 10 months ago (2016-02-24 01:17:09 UTC) #24
Message was sent while issue was closed. 
A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/1727083002/ by shrike@chromium.org.

The reason for reverting is: Regression: WebKit Linux Leak

Suspecting this cl for WebKit leak regression on Linux, from the list of cls
suggested by Sheriff-o-matic (
https://chromium.googlesource.com/chromium/src/+log/b99fe46d578c03c48b5840662...
)

https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak?n...

Beginning in Build #17652 -
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Leak/b...

16:45:41.551 14179 worker/2
fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html
output stderr lines:
16:45:41.551 14179   Xlib:  extension "RANDR" missing on display ":9".
16:45:41.552 14179   Xlib:  extension "RANDR" missing on display ":9".
16:45:41.552 14179  
[31241:31241:0222/164540:1670209790:ERROR:object_proxy.cc(580)] Failed to call
method: org.freedesktop.DBus.ObjectManager.GetManagedObjects: object_path= /:
org.freedesktop.DBus.Error.UnknownMethod: Method "GetManagedObjects" with
signature "" on interface "org.freedesktop.DBus.ObjectManager" doesn't exist
16:45:41.552 14179   
16:45:41.552 14179  
[31241:31241:0222/164540:1670210185:WARNING:object_manager.cc(370)] org.bluez /:
Failed to get managed objects
16:45:41.552 14179  
[31241:31241:0222/164540:1670212252:ERROR:object_proxy.cc(580)] Failed to call
method: org.freedesktop.DBus.ObjectManager.GetManagedObjects: object_path= /:
org.freedesktop.DBus.Error.UnknownMethod: Method "GetManagedObjects" with
signature "" on interface "org.freedesktop.DBus.ObjectManager" doesn't exist
16:45:41.552 14179   
16:45:41.552 14179  
[31241:31241:0222/164540:1670212556:WARNING:object_manager.cc(370)] org.bluez /:
Failed to get managed objects
16:45:41.552 14179  
[31241:31349:0222/164540:1670222703:ERROR:zygote_host_impl_linux.cc(162)] Failed
to adjust OOM score of renderer with pid 31366: Permission denied
16:45:41.582 14179 "/usr/bin/wdiff --help" took 0.03s
16:45:41.614 14179 "/usr/bin/wdiff --start-delete=##WDIFF_DEL##
--end-delete=##WDIFF_END## --start-insert=##WDIFF_ADD##
--end-insert=##WDIFF_END##
/mnt/data/b/build/slave/WebKit_Linux_Leak/build/layout-test-results/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-expected.txt
/mnt/data/b/build/slave/WebKit_Linux_Leak/build/layout-test-results/fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced-actual.txt"
took 0.03s
16:45:41.646 14179 "ruby --version" took 0.03s
.
.
.
Regressions: Unexpected text-only failures (1)
 
fast/dom/Window/property-access-on-cached-properties-after-frame-removed-and-gced.html
[ Failure Failure Failure Leak ]

Regressions: Unexpected leaks (2)
 
fast/dom/Window/property-access-on-cached-properties-after-frame-navigated.html
[ Leak Leak Failure Failure ]
  fast/dom/Window/property-access-on-cached-properties-after-frame-removed.html
[ Leak Leak Leak Failure ]
.

Powered by Google App Engine
This is Rietveld 408576698