chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java - Issue 1711063002: Avoid disk reads in TabPersistentStore for max tab_id.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java

Issue 1711063002: Avoid disk reads in TabPersistentStore for max tab_id. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add refactoring to this CL. Created 4 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/tab/TabIdManager.java ('k') | chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabPersistentStore.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java

index 232a88a97211ddf172dbc9115ab855a6bcf4c11a..50daa6face1a6c34d91b4dbd97f1086920311705 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/tabmodel/TabModelSelectorImpl.java

@@ -13,7 +13,6 @@ import org.chromium.chrome.browser.compositor.layouts.OverviewModeBehavior;

import org.chromium.chrome.browser.compositor.layouts.content.TabContentManager;

import org.chromium.chrome.browser.ntp.NativePageFactory;

import org.chromium.chrome.browser.tab.Tab;

-import org.chromium.chrome.browser.tab.TabIdManager;

import org.chromium.chrome.browser.tabmodel.TabModel.TabLaunchType;

import org.chromium.chrome.browser.tabmodel.TabModel.TabSelectionType;

import org.chromium.chrome.browser.tabmodel.TabPersistentStore.TabPersistentStoreObserver;

@@ -278,8 +277,7 @@ public class TabModelSelectorImpl extends TabModelSelectorBase implements TabMod

* tabs shall not be restored until {@link #restoreTabs} is called.

public void loadState() {

- int nextId = mTabSaver.loadState();

- if (nextId >= 0) TabIdManager.getInstance().incrementIdCounterTo(nextId);

+ mTabSaver.loadState();

}

/**