Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(39)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1711053002: Add test for already fixed bug (issue 25730) (Closed)

Created:
4 years, 10 months ago by Brian Wilkerson
Modified:
4 years, 10 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Base URL:
https://github.com/dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 2

Patch Set 2 : address comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+27 lines, -0 lines) Patch
M pkg/analyzer/test/src/task/dart_test.dart View 1 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Brian Wilkerson
4 years, 10 months ago (2016-02-18 19:25:30 UTC) #2
scheglov
https://codereview.chromium.org/1711053002/diff/1/pkg/analyzer/test/src/task/dart_test.dart File pkg/analyzer/test/src/task/dart_test.dart (right): https://codereview.chromium.org/1711053002/diff/1/pkg/analyzer/test/src/task/dart_test.dart#newcode1169 pkg/analyzer/test/src/task/dart_test.dart:1169: // the set [x, constructorForD]. I don't understand this ...
4 years, 10 months ago (2016-02-18 19:29:13 UTC) #3
Brian Wilkerson
https://codereview.chromium.org/1711053002/diff/1/pkg/analyzer/test/src/task/dart_test.dart File pkg/analyzer/test/src/task/dart_test.dart (right): https://codereview.chromium.org/1711053002/diff/1/pkg/analyzer/test/src/task/dart_test.dart#newcode1169 pkg/analyzer/test/src/task/dart_test.dart:1169: // the set [x, constructorForD]. Sorry, copy-paste error.
4 years, 10 months ago (2016-02-18 19:36:39 UTC) #4
scheglov
LGTM
4 years, 10 months ago (2016-02-18 20:18:21 UTC) #5
Brian Wilkerson
4 years, 10 months ago (2016-02-18 20:54:36 UTC) #7
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
41b9a28cef2250b22186b33f5e6ac9b0c616e221 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698