Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(28)

Issue 1711003002: Don't call deprecated "isPotentiallyMutated..." API from analysis server. (Closed)

Created:
4 years, 10 months ago by Paul Berry
Modified:
4 years, 10 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org
Base URL:
git@github.com:dart-lang/sdk.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Don't call deprecated "isPotentiallyMutated..." API from analysis server. Analysis server's use of this API was just for generating debug status anyhow. R=brianwilkerson@google.com Committed: https://github.com/dart-lang/sdk/commit/12a7ccaa5254ec9e052dfcc246aaf5723bdbe5d9

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -18 lines) Patch
M pkg/analysis_server/lib/src/status/validator.dart View 1 chunk +0 lines, -18 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Paul Berry
4 years, 10 months ago (2016-02-18 18:02:12 UTC) #2
Brian Wilkerson
LGTM
4 years, 10 months ago (2016-02-18 18:05:51 UTC) #3
Paul Berry
4 years, 10 months ago (2016-02-18 18:20:53 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
12a7ccaa5254ec9e052dfcc246aaf5723bdbe5d9 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698