Merge r21417 to 172....

Merge r21417 to 172.

(Part 1, r22067 to follow)

Add support to URLRequest for deferring redirects.

I chose to add an out parameter to OnReceivedRedirect because it allows for the
default behavior to remain the same.

I considered adding a ContinueAfterRedirect method that all OnReceivedRedirect
implementations would need to call, but this caused one annoying problem:  In
the case of a ChromePlugin, it is possible for the URLRequest to get deleted
inside the handler for the redirect.  This would make it hard to subsequently
call a method on the URLRequest since I would need to have a way to determine
if the URLRequest had been deleted.

TEST=covered by unit tests
BUG=16413, 6442
R=eroman,wtc


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23616

[darin (slow to review), 2009-08-18 05:58:12]

LGTM

[Mark Larson, 2009-08-18 06:22:36]

Final patch set that I'm going to commit.

http://codereview.chromium.org/171099/diff/1/9
File net/url_request/url_request.cc (right):

http://codereview.chromium.org/171099/diff/1/9#newcode350
Line 350: job_->Kill();
Not sure how this made it in. Need to kill it and find out if it's missing from
somewhere else.

Need to check final CL vs. this review.

This is OK. It's in the final CL (just not in
http://codereview.chromium.org/155897)

[darin (slow to review), 2009-08-18 06:45:05]

LGTM

http://codereview.chromium.org/171099/diff/1/9
File net/url_request/url_request.cc (right):

http://codereview.chromium.org/171099/diff/1/9#newcode350
Line 350: job_->Kill();
On 2009/08/18 06:22:36, Mark Larson wrote:
> Not sure how this made it in. Need to kill it and find out if it's missing
from
> somewhere else.
> 
> Need to check final CL vs. this review.
> 
> This is OK. It's in the final CL (just not in
> http://codereview.chromium.org/155897)
> 

Good catch.  That is redundant.  IIRC, I was planning on moving it from the
callsite of OrphanJob.  It is harmless that it is called twice.