Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(439)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1710983002: Make build_command_buffer.py work on Windows (Closed)

Created:
4 years, 10 months ago by bsalomon
Modified:
4 years, 10 months ago
Reviewers:
borenet
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : remove debug print #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -19 lines) Patch
M tools/build_command_buffer.py View 1 4 chunks +21 lines, -19 lines 0 comments Download

Messages

Total messages: 9 (5 generated)
bsalomon
A couple tweaks to actually work on Windows.
4 years, 10 months ago (2016-02-18 17:26:22 UTC) #4
borenet
LGTM
4 years, 10 months ago (2016-02-18 17:35:44 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710983002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710983002/20001
4 years, 10 months ago (2016-02-18 17:39:17 UTC) #7
commit-bot: I haz the power
4 years, 10 months ago (2016-02-18 18:01:15 UTC) #9
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/1526e0a5f5d975b34878ed46c2e5fc1671fdac76

Powered by Google App Engine
This is Rietveld 408576698