Issue 171097: The 2 layout test regressions happened due to changes in the test shell....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171097: The 2 layout test regressions happened due to changes in the test shell.... (Closed)

Created:
11 years, 4 months ago by jorlow

Modified:
9 years, 6 months ago

Reviewers:
darin (slow to review)

CC:
chromium-reviews_googlegroups.com, darin (slow to review)

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

The 2 layout test regressions happened due to changes in the test shell. After looking at the diff, I realized that I had changed the behavior more than necessary. So I've reverted back the parts that were using the web settings API directly and now they're setting properties on their web preferences object and then just applying that to the web view. This should match the behavior of before. This is fixing some behavior committed in http://src.chromium.org/viewvc/chrome?view=rev&revision=23589 TEST=none BUG=19544

Patch Set 1 #

Patch Set 2 : '' #

Total comments: 1

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+16 lines, -18 lines)			Patch
M	webkit/tools/layout_tests/test_expectations.txt	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	webkit/tools/test_shell/layout_test_controller.cc	View	4 chunks	+9 lines, -6 lines	1 comment	Download
M	webkit/tools/test_shell/test_webview_delegate.cc	View	2 chunks	+7 lines, -8 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

darin (slow to review)

11 years, 4 months ago (2009-08-18 18:02:47 UTC) #2

LGTM

http://codereview.chromium.org/171097/diff/2001/2004
File webkit/tools/test_shell/layout_test_controller.cc (right):

http://codereview.chromium.org/171097/diff/2001/2004#newcode708
Line 708: WebPreferences* prefs = shell_->GetWebPreferences();
nit: 2 space indent

Expand Messages | Collapse Messages