src/js/json.js - Issue 1710933002: Optimize JSON stringifying when `replacer` and `space` are falsey.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/js/json.js

Issue 1710933002: Optimize JSON stringifying when `replacer` and `space` are falsey. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Shift checks to bottom of the function. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/js/json.js

diff --git a/src/js/json.js b/src/js/json.js

index e72c1f68cb654af872fc5865c0fd5a077f5bba88..6f68f3c2455323a2dc0e619364e9766cfb74e754 100644

--- a/src/js/json.js

+++ b/src/js/json.js

@@ -234,6 +234,9 @@ function JSONStringify(value, replacer, space) {

} else {

gap = "";

}

Yang 2016/02/19 10:36:34 whitespace before "!gap".

+ if (!IS_CALLABLE(replacer) && !property_list &&!gap && !IS_PROXY(value)) {

+ return %BasicJSONStringify(value);

+ }

return JSONSerialize('', {'': value}, replacer, new InternalArray(), "", gap);

}

« no previous file with comments | « no previous file | no next file » | no next file with comments »