Optimize JSON stringifying when `replacer` and `space` are falsey.

Optimize JSON stringifying when `replacer` and `space` are falsey.

Most libraries use `JSON.stringify` with all three arguments [1] to allow for
configuration, even if `replacer` and `space` are falsey, causing the
optimized native stringifying to be missed. This commit allows for the common
case where `replacer` and `space` are not used to be fast.

[1]: https://github.com/hapijs/hapi/pull/3014

BUG=v8:4730
LOG=N

R=yangguo@chromium.org

Committed: https://crrev.com/26f617f1bc63e2b28bd9ea5f2146ad3a6b57396f
Cr-Commit-Position: refs/heads/master@{#34174}

[Yang, 2016-02-18 16:08:22]

On 2016/02/18 15:21:33, demoneaux wrote:

Not lgtm. this step is observable and does not match the spec. you can define a
valueOf function that get's called at that step.

[Benjamin Tan, 2016-02-19 09:58:28]

On 2016/02/18 16:08:22, Yang wrote:
> On 2016/02/18 15:21:33, demoneaux wrote:
> 
> Not lgtm. this step is observable and does not match the spec. you can define
a
> valueOf function that get's called at that step.

I've updated this to shift the checks to the bottom of the function after the
checks for `replacer` and `space`. PTAL.

[Yang, 2016-02-19 10:36:34]

LTGM with nit. Please put yourself into the AUTHORS file if you haven't yet.

https://codereview.chromium.org/1710933002/diff/20001/src/js/json.js
File src/js/json.js (right):

https://codereview.chromium.org/1710933002/diff/20001/src/js/json.js#newcode236
src/js/json.js:236: }
whitespace before "!gap".

[Benjamin Tan, 2016-02-20 04:46:35]

On 2016/02/19 10:36:34, Yang wrote:
> LTGM with nit. Please put yourself into the AUTHORS file if you haven't yet.
> 
> https://codereview.chromium.org/1710933002/diff/20001/src/js/json.js
> File src/js/json.js (right):
> 
>
https://codereview.chromium.org/1710933002/diff/20001/src/js/json.js#newcode236
> src/js/json.js:236: }
> whitespace before "!gap".

I've updated to fix the nit, and added myself to the AUTHORS file. Thanks for
taking the time to review this!

[Yang, 2016-02-20 07:07:24]

On 2016/02/20 04:46:35, demoneaux wrote:
> On 2016/02/19 10:36:34, Yang wrote:
> > LTGM with nit. Please put yourself into the AUTHORS file if you haven't yet.
> > 
> > https://codereview.chromium.org/1710933002/diff/20001/src/js/json.js
> > File src/js/json.js (right):
> > 
> >
>
https://codereview.chromium.org/1710933002/diff/20001/src/js/json.js#newcode236
> > src/js/json.js:236: }
> > whitespace before "!gap".
> 
> I've updated to fix the nit, and added myself to the AUTHORS file. Thanks for
> taking the time to review this!

lgtm. (mistyped before). You can check the "commit" checkbox to land this
change.

[Yang, 2016-02-20 07:13:43]

On 2016/02/20 07:07:24, Yang wrote:
> On 2016/02/20 04:46:35, demoneaux wrote:
> > On 2016/02/19 10:36:34, Yang wrote:
> > > LTGM with nit. Please put yourself into the AUTHORS file if you haven't
yet.
> > > 
> > > https://codereview.chromium.org/1710933002/diff/20001/src/js/json.js
> > > File src/js/json.js (right):
> > > 
> > >
> >
>
https://codereview.chromium.org/1710933002/diff/20001/src/js/json.js#newcode236
> > > src/js/json.js:236: }
> > > whitespace before "!gap".
> > 
> > I've updated to fix the nit, and added myself to the AUTHORS file. Thanks
for
> > taking the time to review this!
> 
> lgtm. (mistyped before). You can check the "commit" checkbox to land this
> change.

Btw, a way better solution would be adding handling for replacer and whitespace
to the C++ implementation, if you are interested :)

[Benjamin Tan, 2016-02-20 07:27:32]

The CQ bit was checked by demoneaux@gmail.com

[commit-bot: I haz the power, 2016-02-20 07:27:41]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1710933002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1710933002/40001

[Yang, 2016-02-20 07:29:30]

Description was changed from

==========
Optimize JSON stringifying when `replacer` and `space` are falsey.

Most libraries use `JSON.stringify` with all three arguments [1] to allow for
configuration, even if `replacer` and `space` are falsey, causing the
optimized native stringifying to be missed. This commit allows for the common
case where `replacer` and `space` are not used to be fast.

[1]: https://github.com/hapijs/hapi/pull/3014

BUG=4730

R=yangguo@chromium.org
==========

to

==========
Optimize JSON stringifying when `replacer` and `space` are falsey.

Most libraries use `JSON.stringify` with all three arguments [1] to allow for
configuration, even if `replacer` and `space` are falsey, causing the
optimized native stringifying to be missed. This commit allows for the common
case where `replacer` and `space` are not used to be fast.

[1]: https://github.com/hapijs/hapi/pull/3014

BUG=v8:4730
LOG=N

R=yangguo@chromium.org
==========

[Benjamin Tan, 2016-02-20 07:53:26]

On 2016/02/20 07:13:43, Yang wrote:
> On 2016/02/20 07:07:24, Yang wrote:
> > On 2016/02/20 04:46:35, demoneaux wrote:
> > > On 2016/02/19 10:36:34, Yang wrote:
> > > > LTGM with nit. Please put yourself into the AUTHORS file if you haven't
> yet.
> > > > 
> > > > https://codereview.chromium.org/1710933002/diff/20001/src/js/json.js
> > > > File src/js/json.js (right):
> > > > 
> > > >
> > >
> >
>
https://codereview.chromium.org/1710933002/diff/20001/src/js/json.js#newcode236
> > > > src/js/json.js:236: }
> > > > whitespace before "!gap".
> > > 
> > > I've updated to fix the nit, and added myself to the AUTHORS file. Thanks
> for
> > > taking the time to review this!
> > 
> > lgtm. (mistyped before). You can check the "commit" checkbox to land this
> > change.
> 
> Btw, a way better solution would be adding handling for replacer and
whitespace
> to the C++ implementation, if you are interested :)

I might take a look at that, although my C++ isn't very good :(

[commit-bot: I haz the power, 2016-02-20 07:55:37]

Description was changed from

==========
Optimize JSON stringifying when `replacer` and `space` are falsey.

Most libraries use `JSON.stringify` with all three arguments [1] to allow for
configuration, even if `replacer` and `space` are falsey, causing the
optimized native stringifying to be missed. This commit allows for the common
case where `replacer` and `space` are not used to be fast.

[1]: https://github.com/hapijs/hapi/pull/3014

BUG=v8:4730
LOG=N

R=yangguo@chromium.org
==========

to

==========
Optimize JSON stringifying when `replacer` and `space` are falsey.

Most libraries use `JSON.stringify` with all three arguments [1] to allow for
configuration, even if `replacer` and `space` are falsey, causing the
optimized native stringifying to be missed. This commit allows for the common
case where `replacer` and `space` are not used to be fast.

[1]: https://github.com/hapijs/hapi/pull/3014

BUG=v8:4730
LOG=N

R=yangguo@chromium.org
==========

[commit-bot: I haz the power, 2016-02-20 07:55:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-02-20 07:56:05]

Description was changed from

==========
Optimize JSON stringifying when `replacer` and `space` are falsey.

Most libraries use `JSON.stringify` with all three arguments [1] to allow for
configuration, even if `replacer` and `space` are falsey, causing the
optimized native stringifying to be missed. This commit allows for the common
case where `replacer` and `space` are not used to be fast.

[1]: https://github.com/hapijs/hapi/pull/3014

BUG=v8:4730
LOG=N

R=yangguo@chromium.org
==========

to

==========
Optimize JSON stringifying when `replacer` and `space` are falsey.

Most libraries use `JSON.stringify` with all three arguments [1] to allow for
configuration, even if `replacer` and `space` are falsey, causing the
optimized native stringifying to be missed. This commit allows for the common
case where `replacer` and `space` are not used to be fast.

[1]: https://github.com/hapijs/hapi/pull/3014

BUG=v8:4730
LOG=N

R=yangguo@chromium.org

Committed: https://crrev.com/26f617f1bc63e2b28bd9ea5f2146ad3a6b57396f
Cr-Commit-Position: refs/heads/master@{#34174}
==========

[commit-bot: I haz the power, 2016-02-20 07:56:06]

Patchset 3 (id:??) landed as
https://crrev.com/26f617f1bc63e2b28bd9ea5f2146ad3a6b57396f
Cr-Commit-Position: refs/heads/master@{#34174}