Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 1710933002: Optimize JSON stringifying when `replacer` and `space` are falsey. (Closed)

Created:
4 years, 10 months ago by Benjamin Tan
Modified:
4 years, 10 months ago
Reviewers:
Yang
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Optimize JSON stringifying when `replacer` and `space` are falsey. Most libraries use `JSON.stringify` with all three arguments [1] to allow for configuration, even if `replacer` and `space` are falsey, causing the optimized native stringifying to be missed. This commit allows for the common case where `replacer` and `space` are not used to be fast. [1]: https://github.com/hapijs/hapi/pull/3014 BUG=v8:4730 LOG=N R=yangguo@chromium.org Committed: https://crrev.com/26f617f1bc63e2b28bd9ea5f2146ad3a6b57396f Cr-Commit-Position: refs/heads/master@{#34174}

Patch Set 1 #

Patch Set 2 : Shift checks to bottom of the function. #

Total comments: 1

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -0 lines) Patch
M AUTHORS View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M src/js/json.js View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (4 generated)
Benjamin Tan
4 years, 10 months ago (2016-02-18 15:21:33 UTC) #1
Yang
On 2016/02/18 15:21:33, demoneaux wrote: Not lgtm. this step is observable and does not match ...
4 years, 10 months ago (2016-02-18 16:08:22 UTC) #2
Benjamin Tan
On 2016/02/18 16:08:22, Yang wrote: > On 2016/02/18 15:21:33, demoneaux wrote: > > Not lgtm. ...
4 years, 10 months ago (2016-02-19 09:58:28 UTC) #3
Yang
LTGM with nit. Please put yourself into the AUTHORS file if you haven't yet. https://codereview.chromium.org/1710933002/diff/20001/src/js/json.js ...
4 years, 10 months ago (2016-02-19 10:36:34 UTC) #4
Benjamin Tan
On 2016/02/19 10:36:34, Yang wrote: > LTGM with nit. Please put yourself into the AUTHORS ...
4 years, 10 months ago (2016-02-20 04:46:35 UTC) #5
Yang
On 2016/02/20 04:46:35, demoneaux wrote: > On 2016/02/19 10:36:34, Yang wrote: > > LTGM with ...
4 years, 10 months ago (2016-02-20 07:07:24 UTC) #6
Yang
On 2016/02/20 07:07:24, Yang wrote: > On 2016/02/20 04:46:35, demoneaux wrote: > > On 2016/02/19 ...
4 years, 10 months ago (2016-02-20 07:13:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710933002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710933002/40001
4 years, 10 months ago (2016-02-20 07:27:41 UTC) #9
Benjamin Tan
On 2016/02/20 07:13:43, Yang wrote: > On 2016/02/20 07:07:24, Yang wrote: > > On 2016/02/20 ...
4 years, 10 months ago (2016-02-20 07:53:26 UTC) #11
commit-bot: I haz the power
Committed patchset #3 (id:40001)
4 years, 10 months ago (2016-02-20 07:55:38 UTC) #13
commit-bot: I haz the power
4 years, 10 months ago (2016-02-20 07:56:06 UTC) #15
Message was sent while issue was closed.
Patchset 3 (id:??) landed as
https://crrev.com/26f617f1bc63e2b28bd9ea5f2146ad3a6b57396f
Cr-Commit-Position: refs/heads/master@{#34174}

Powered by Google App Engine
This is Rietveld 408576698