Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 171093002: NaCl: Move definition of the "ppapihook" IRT interface to the Chromium repo (Closed)

Created:
6 years, 10 months ago by Mark Seaborn
Modified:
6 years, 10 months ago
Reviewers:
teravest, bradn
CC:
chromium-reviews, jvoung (off chromium)
Visibility:
Public.

Description

NaCl: Move definition of the "ppapihook" IRT interface to the Chromium repo This uses the new IRT construction API. This will allow references to PPAPI to be removed from src/untrusted/irt in the NaCl repo. BUG=https://code.google.com/p/nativeclient/issues/detail?id=3787 TEST=browser_tests Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252119

Patch Set 1 #

Patch Set 2 : Update #

Patch Set 3 : Use Chrome * style #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -0 lines) Patch
M ppapi/proxy/irt_ppapi.c View 1 2 2 chunks +24 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Mark Seaborn
6 years, 10 months ago (2014-02-19 16:22:28 UTC) #1
teravest
lgtm
6 years, 10 months ago (2014-02-19 16:30:04 UTC) #2
bradn
lgtm
6 years, 10 months ago (2014-02-19 16:54:11 UTC) #3
Mark Seaborn
The CQ bit was checked by mseaborn@chromium.org
6 years, 10 months ago (2014-02-19 17:36:23 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mseaborn@chromium.org/171093002/60001
6 years, 10 months ago (2014-02-19 17:40:38 UTC) #5
commit-bot: I haz the power
6 years, 10 months ago (2014-02-19 22:44:48 UTC) #6
Message was sent while issue was closed.
Change committed as 252119

Powered by Google App Engine
This is Rietveld 408576698