Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(154)

Issue 1710903002: Revert of service worker: use 200 OK for update requests even in the no update case (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
CC:
blink-reviews, blink-reviews-api_chromium.org, blink-worker-reviews_chromium.org, chromium-reviews, darin-cc_chromium.org, dglazkov+blink, horo+watch_chromium.org, jam, jsbell+serviceworker_chromium.org, kinuko+serviceworker, kinuko+watch, michaeln, mkwst+moarreviews-renderer_chromium.org, mlamouri+watch-content_chromium.org, serviceworker-reviews, tzik
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of service worker: use 200 OK for update requests even in the no update case (patchset #8 id:140001 of https://codereview.chromium.org/1675613002/ ) Reason for revert: https://build.chromium.org/p/chromium.memory/builders/Linux%20ASan%20LSan%20Tests%20%281%29?numbuilds=200 got much more flaky after this landed. Speculatively revert and see if it helps. See also http://crbug.com/586897 Original issue's description: > service worker: use 200 OK for update requests even in the no update case > > The main motivation is to stop network failure error spew in DevTools console. > This patch reinstates the "pause on download" functionality we once had. > > BUG=541797 > > Committed: https://crrev.com/42bc9253c79fa01fc6a6af5b3908dcc063a12023 > Cr-Commit-Position: refs/heads/master@{#376032} TBR=tkent@chromium.org,michaeln@chromium.org,nhiroki@chromium.org,tsepez@chromium.org,falken@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=541797 Committed: https://crrev.com/5e2979f2431af7f900242b0a8c9e02c4f7dfe1db Cr-Commit-Position: refs/heads/master@{#376161}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+72 lines, -343 lines) Patch
M content/browser/service_worker/embedded_worker_instance.h View 2 chunks +3 lines, -9 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 4 chunks +1 line, -15 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 2 chunks +3 lines, -33 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.h View 2 chunks +1 line, -4 lines 0 comments Download
M content/browser/service_worker/embedded_worker_test_helper.cc View 3 chunks +2 lines, -19 lines 0 comments Download
M content/browser/service_worker/service_worker_controllee_request_handler_unittest.cc View 1 chunk +1 line, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_job_unittest.cc View 8 chunks +11 lines, -51 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.h View 3 chunks +1 line, -6 lines 0 comments Download
M content/browser/service_worker/service_worker_register_job.cc View 7 chunks +12 lines, -34 lines 0 comments Download
M content/browser/service_worker/service_worker_registration.h View 1 chunk +0 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_version.h View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 chunk +1 line, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_version_unittest.cc View 2 chunks +3 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job.h View 2 chunks +2 lines, -7 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job.cc View 3 chunks +12 lines, -5 lines 0 comments Download
M content/browser/service_worker/service_worker_write_to_cache_job_unittest.cc View 1 chunk +0 lines, -1 line 0 comments Download
M content/common/service_worker/embedded_worker_messages.h View 2 chunks +0 lines, -6 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_dispatcher.h View 1 chunk +0 lines, -1 line 0 comments Download
M content/renderer/service_worker/embedded_worker_dispatcher.cc View 3 chunks +0 lines, -17 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.h View 2 chunks +2 lines, -8 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImpl.cpp View 6 chunks +8 lines, -23 lines 0 comments Download
M third_party/WebKit/Source/web/WebEmbeddedWorkerImplTest.cpp View 4 chunks +3 lines, -72 lines 0 comments Download
M third_party/WebKit/public/web/WebEmbeddedWorker.h View 1 chunk +0 lines, -4 lines 0 comments Download
M third_party/WebKit/public/web/WebEmbeddedWorkerStartData.h View 2 chunks +2 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Nico
Created Revert of service worker: use 200 OK for update requests even in the no ...
4 years, 10 months ago (2016-02-18 13:47:01 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710903002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710903002/1
4 years, 10 months ago (2016-02-18 13:47:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 10 months ago (2016-02-18 13:48:39 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/5e2979f2431af7f900242b0a8c9e02c4f7dfe1db Cr-Commit-Position: refs/heads/master@{#376161}
4 years, 10 months ago (2016-02-18 13:49:27 UTC) #5
Nico
4 years, 10 months ago (2016-02-18 19:30:56 UTC) #6
Message was sent while issue was closed.
looks like this helped, bot had 6 consecutive green runs after this went in,
preceded by 11 out of 12 failing before the revert

Powered by Google App Engine
This is Rietveld 408576698