Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(3)

Issue 17109007: Miscellaneous cleanup of TLS 1.2 code. (Closed)

Created:
6 years ago by wtc
Modified:
6 years ago
Reviewers:
agl
CC:
chromium-reviews, cbentzel+watch_chromium.org
Visibility:
Public.

Description

Miscellaneous cleanup of TLS 1.2 code. 1. Support TLS 1.2 in PKCS #11 bypass mode. 2. Delay the creation of handshake hash contexts until we have established the handshake hash functions. 3. Buffer handshake messages until the handshake hash contexts have been created. 4. Fix the double ssl3_RestartHandshakeHashes calls, by removing the ssl3_RestartHandshakeHashes call in ssl3_NewHandshakeHashes. 5. Remove redundant ssl3_InitState calls. 6. Remove NSS_SURVIVE_DOUBLE_BYPASS_FAILURE support, so that ss->ssl3.hs.messages is used for only one purpose. R=agl@chromium.org BUG=90392 TEST=none Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=206827

Patch Set 1 #

Patch Set 2 : Ready for review #

Total comments: 10

Patch Set 3 : Make error handling in ssl3_InitHandshakeHashes more uniform. Include the patch file. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1063 lines, -198 lines) Patch
M net/third_party/nss/README.chromium View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M net/third_party/nss/patches/applypatches.sh View 1 2 1 chunk +2 lines, -0 lines 0 comments Download
A net/third_party/nss/patches/tls12handshakehashes.patch View 1 2 1 chunk +814 lines, -0 lines 0 comments Download
M net/third_party/nss/ssl/derive.c View 1 6 chunks +48 lines, -17 lines 0 comments Download
M net/third_party/nss/ssl/ssl3con.c View 1 2 33 chunks +166 lines, -169 lines 0 comments Download
M net/third_party/nss/ssl/sslimpl.h View 1 2 4 chunks +31 lines, -4 lines 0 comments Download
M net/third_party/nss/ssl/sslsock.c View 2 chunks +1 line, -8 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
wtc
agl: I'm sorry the CL is not easy to review. I added some annotations. Please ...
6 years ago (2013-06-15 19:40:55 UTC) #1
agl
LGTM https://chromiumcodereview.appspot.com/17109007/diff/19001/net/third_party/nss/ssl/ssl3con.c File net/third_party/nss/ssl/ssl3con.c (right): https://chromiumcodereview.appspot.com/17109007/diff/19001/net/third_party/nss/ssl/ssl3con.c#newcode3686 net/third_party/nss/ssl/ssl3con.c:3686: goto loser; Several error paths in this function ...
6 years ago (2013-06-17 14:01:13 UTC) #2
wtc
Thank you for the review. Please review the diffs between patch sets 2 and 3. ...
6 years ago (2013-06-17 20:05:15 UTC) #3
agl
lgtm
6 years ago (2013-06-17 20:09:12 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/wtc@chromium.org/17109007/36001
6 years ago (2013-06-17 20:10:20 UTC) #5
commit-bot: I haz the power
6 years ago (2013-06-17 23:14:00 UTC) #6
Message was sent while issue was closed.
Change committed as 206827

Powered by Google App Engine
This is Rietveld 408576698