chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java - Issue 1710853002: android: Add a method to let Java know whether a prerender has finished loading.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

Issue 1710853002: android: Add a method to let Java know whether a prerender has finished loading. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Address comments. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | chrome/android/java/src/org/chromium/chrome/browser/prerender/ExternalPrerenderHandler.java » ('j') | chrome/browser/prerender/external_prerender_handler_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

diff --git a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

index 5fcec5db02908136a8cb2c31b35643c0db31b090..2d7cddc936bd1efe10b660f9b5c4c3be275b1105 100644

--- a/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

+++ b/chrome/android/java/src/org/chromium/chrome/browser/customtabs/CustomTabsConnection.java

@@ -77,7 +77,8 @@ public class CustomTabsConnection extends ICustomTabsService.Stub {

private static AtomicReference<CustomTabsConnection> sInstance =

new AtomicReference<CustomTabsConnection>();

- private static final class PrerenderedUrlParams {

+ @VisibleForTesting

+ static final class PrerenderedUrlParams {

public final IBinder mSession;

public final WebContents mWebContents;

public final String mUrl;

@@ -94,12 +95,13 @@ public class CustomTabsConnection extends ICustomTabsService.Stub {

}

+ @VisibleForTesting

+ PrerenderedUrlParams mPrerender;

protected final Application mApplication;

private final boolean mLogRequests;

private final AtomicBoolean mWarmupHasBeenCalled = new AtomicBoolean();

private final ClientManager mClientManager;

private ExternalPrerenderHandler mExternalPrerenderHandler;

- private PrerenderedUrlParams mPrerender;

private WebContents mSpareWebContents;

/**