Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(202)

Issue 1710753002: Fix an assertion failure in CXFA_FWLTheme::Initialize() (Closed)

Created:
4 years, 10 months ago by jun_fang
Modified:
4 years, 10 months ago
Reviewers:
Tom Sepez, Lei Zhang
CC:
pdfium-reviews_googlegroups.com, Jim Wang, kai_jing
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix an assertion failure in CXFA_FWLTheme::Initialize() The face names from font file stream may be different with the ones from chromium. Pdfium should save face names from chromium for font mapping when it works in sandbox environment. BUG=pdfium:392 BUG=pdfium:393 R=tsepez@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/c5967f9dbaee98e8ac8302a62e015e5c595aa6e0

Patch Set 1 #

Total comments: 2

Patch Set 2 : nit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -15 lines) Patch
M xfa/src/fgas/src/font/fx_stdfontmgr.h View 1 chunk +6 lines, -4 lines 0 comments Download
M xfa/src/fgas/src/font/fx_stdfontmgr.cpp View 1 7 chunks +18 lines, -11 lines 0 comments Download

Messages

Total messages: 7 (3 generated)
jun_fang
Hi Tom and Lei, Please help to review this CL. Thanks!
4 years, 10 months ago (2016-02-18 09:38:10 UTC) #3
Tom Sepez
LGTM with nit. https://codereview.chromium.org/1710753002/diff/1/xfa/src/fgas/src/font/fx_stdfontmgr.cpp File xfa/src/fgas/src/font/fx_stdfontmgr.cpp (right): https://codereview.chromium.org/1710753002/diff/1/xfa/src/fgas/src/font/fx_stdfontmgr.cpp#newcode622 xfa/src/fgas/src/font/fx_stdfontmgr.cpp:622: CFX_WideString wsFaceName; nit: can we delcare ...
4 years, 10 months ago (2016-02-18 19:46:54 UTC) #4
jun_fang
https://codereview.chromium.org/1710753002/diff/1/xfa/src/fgas/src/font/fx_stdfontmgr.cpp File xfa/src/fgas/src/font/fx_stdfontmgr.cpp (right): https://codereview.chromium.org/1710753002/diff/1/xfa/src/fgas/src/font/fx_stdfontmgr.cpp#newcode622 xfa/src/fgas/src/font/fx_stdfontmgr.cpp:622: CFX_WideString wsFaceName; On 2016/02/18 19:46:54, Tom Sepez wrote: > ...
4 years, 10 months ago (2016-02-19 00:14:04 UTC) #5
jun_fang
4 years, 10 months ago (2016-02-19 00:40:54 UTC) #7
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
c5967f9dbaee98e8ac8302a62e015e5c595aa6e0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698