third_party/WebKit/Source/core/fetch/Resource.h - Issue 1710733002: Move multipart resource handling to core/fetch (2/2)

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/fetch/Resource.h

Issue 1710733002: Move multipart resource handling to core/fetch (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multipart-cleanup

Patch Set: rebase Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/core/fetch/ImageResource.cpp ('K') | « third_party/WebKit/Source/core/fetch/MultipartImageResourceParserTest.cpp ('k') | third_party/WebKit/Source/core/fetch/Resource.cpp » ('j') | third_party/WebKit/Source/core/fetch/ResourceLoader.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/fetch/Resource.h

diff --git a/third_party/WebKit/Source/core/fetch/Resource.h b/third_party/WebKit/Source/core/fetch/Resource.h

index 2dd436953333993acbc6cce65d52bdc257d6a37b..1bea4ff2585c02ea93c8989744f9e5054adca8d8 100644

--- a/third_party/WebKit/Source/core/fetch/Resource.h

+++ b/third_party/WebKit/Source/core/fetch/Resource.h

@@ -175,7 +175,7 @@ public:

// Computes the status of an object after loading.

// Updates the expire date on the cache entry file

void setLoadFinishTime(double finishTime) { m_loadFinishTime = finishTime; }

- void finish();

+ virtual void finish();

// FIXME: Remove the stringless variant once all the callsites' error messages are updated.

bool passesAccessControlCheck(SecurityOrigin*) const;

@@ -270,7 +270,6 @@ protected:

Resource(const ResourceRequest&, Type);

virtual void checkNotify();

- virtual void finishOnePart();

virtual void destroyDecodedDataForFailedRevalidation() { }