Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(323)

Unified Diff: third_party/WebKit/Source/core/fetch/ImageResource.cpp

Issue 1710733002: Move multipart resource handling to core/fetch (2/2) (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@multipart-cleanup
Patch Set: rebase Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/fetch/ImageResource.cpp
diff --git a/third_party/WebKit/Source/core/fetch/ImageResource.cpp b/third_party/WebKit/Source/core/fetch/ImageResource.cpp
index 30e13864b184ef5e48bd4a9c0070ccbe5bc0b853..f77cb73636cc7317ee5928022b22ff317238107b 100644
--- a/third_party/WebKit/Source/core/fetch/ImageResource.cpp
+++ b/third_party/WebKit/Source/core/fetch/ImageResource.cpp
@@ -293,9 +293,9 @@ inline void ImageResource::clearImage()
m_image.clear();
}
-void ImageResource::appendData(const char* data, size_t length)
+void ImageResource::appendDataInternal(const char* data, size_t length)
{
- Resource::appendData(data, length);
+ Resource::appendDataInternal(data, length);
if (!loadingMultipartContent())
updateImage(false);
}
@@ -352,7 +352,8 @@ void ImageResource::error(Resource::Status status)
void ImageResource::responseReceived(const ResourceResponse& response, PassOwnPtr<WebDataConsumerHandle> handle)
{
- if (loadingMultipartContent() && m_data)
+ ASSERT(!handle);
+ if (response.isMultipartPayload() && m_data)
finishOnePart();
Resource::responseReceived(response, handle);
if (RuntimeEnabledFeatures::clientHintsEnabled()) {
@@ -467,7 +468,7 @@ bool ImageResource::isAccessAllowed(SecurityOrigin* securityOrigin)
bool ImageResource::loadingMultipartContent() const
{
- return m_loader && m_loader->loadingMultipartContent();
+ return m_loader && isMultipartImage();
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698