Move multipart resource handling to core/fetch (2/2)

components/page_load_metrics/renderer/metrics_render_frame_observer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/page_load_metrics/renderer/metrics_render_frame_observer.h"
 
 #include <string>
 
 #include "base/time/time.h"
 #include "base/timer/timer.h"
@@ skipping 69 matching lines @@
   if (frame->parent())
     return false;
 
   const blink::WebDocument& document = frame->document();
   // Ignore non-HTTP schemes (e.g. chrome://).
   const GURL& url = document.url();
   if (!url.SchemeIsHTTPOrHTTPS())
     return false;
 
   const blink::WebURLResponse& url_response = frame->dataSource()->response();
-  // Ignore multipart responses (e.g. MHTML).

[Charlie Harrison, 2016/03/07 20:07:05]

Can you explain why this check isn't needed (along with the check in
page_load_histograms)?

[yhirano, 2016/03/07 20:18:27]

Previously isMultipartPayload is set only for multipart/x-replace-image
responses[1] and I'm removing the flag now. IIUC MHTML is not related to this
flag.

For multipart/x-replace-image responses the function should return false based
on the mime type as implemented below.

1:
https://code.google.com/p/chromium/codesearch#chromium/src/content/child/mult...

-  if (url_response.isMultipartPayload())
-    return false;
 
   // Ignore non-HTML documents (e.g. SVG). Note that images are treated by
   // Blink as HTML documents, so to exclude images, we must perform
   // additional mime type checking below.
   if (!document.isHTMLDocument() && !document.isXHTMLDocument())
     return false;
 
   // Ignore non-HTML mime types (e.g. images).
   std::string mime_type = url_response.mimeType().utf8();
   if (mime_type != "text/html" && mime_type != "application/xhtml+xml")
@@ skipping 27 matching lines @@
   return make_scoped_ptr(new base::OneShotTimer);
 }
 
 bool MetricsRenderFrameObserver::HasNoRenderFrame() const {
   bool no_frame = !render_frame() || !render_frame()->GetWebFrame();
   DCHECK(!no_frame);
   return no_frame;
 }
 
 }  // namespace page_load_metrics