Move media/capture/webm_muxer* to media/muxers

Move media/capture/webm_muxer* to media/muxers

WebmMuxer is used to multiplex incoming encoded video
and audio into a webm live stream. It is only used from
content's MediaRecorderHandler.

This CL moves WebmMuxer to media/muxers where it
belongs, since it has nothing to do with capture/; that is
made even more relevant in a parallel CL
(http://crrev.com/1699553002) that isolates the said
media/capture.

This CL doesn't modify code (except a minor style
reformatting caught by the presubmit). Narrowed some
DEPS too.

BUG=584797
Committed: https://crrev.com/7db2a519b8121924ae9b86599e493a0fd68ad4ea
Cr-Commit-Position: refs/heads/master@{#376243}

[mcasas, 2016-02-18 01:20:56]

mcasas@chromium.org changed reviewers:
+ dalecurtis@chromium.org

[mcasas, 2016-02-18 01:20:56]

dalecurtis@ Owners RS please.

[DaleCurtis, 2016-02-18 01:43:39]

I'm not sure /filters/ is the right place for this, it only contains demuxers,
decoders, and parsers. Not muxing. Why shouldn't it stay in capture?

[mcasas, 2016-02-18 02:04:42]

On 2016/02/18 01:43:39, DaleCurtis wrote:
> I'm not sure /filters/ is the right place for this, it only contains demuxers,
> decoders, and parsers. Not muxing. Why shouldn't it stay in capture?

I know we had this conversation before :) but:
- I (still) think muxing is conceptually closer to demuxing 
than to capture :)
- Its only external dependency in media/ is to media/filters 
itself (for opus_constants.h)
- WebmMuxer is not used for capture at all (i.e. no
other classes under capture/ use this one at all)
- the code is fairly stable, hasn't been touched in 
months, so won't be a pain for its new neighbours
- other classes of capture/ are used from content/browser
whereas this only used from content/renderer (and is the only
one which such a dependency graph). 

Makes sense?

[DaleCurtis, 2016-02-18 04:07:19]

Can this be bundled closer to the MediaRecorder classes then? If we do this
you'll also need a per-file OWNERS entry which is generally a bit of an
organizational smell.

[mcasas, 2016-02-18 04:26:36]

On 2016/02/18 04:07:19, DaleCurtis wrote:
> Can this be bundled closer to the MediaRecorder classes then? If we do this
> you'll also need a per-file OWNERS entry which is generally a bit of an
> organizational smell.

MediaRecorder classes are in content/renderer/media.

Where else would you suggest hanging this file admitting
is not at home in capture/ ?

[mcasas, 2016-02-18 18:40:34]

Description was changed from

==========
Move media/capture/webm_muxer* to media/filters

WebmMuxer is used to multiplex incoming encoded video and audio into
a webm live stream. It is used from content's MediaRecorderHandler.

This CL moves WebmMuxer to media/filters where it belongs, since it
has nothing to do with capture/; that is made even more relevant
in a parallel CL (http://crrev.com/1699553002) that isolates the said
media/capture.

This CL doesn't modify code (except a minor style reformatting caught
by the presubmit).

BUG=584797
==========

to

==========
Move media/capture/webm_muxer* to media/muxers

WebmMuxer is used to multiplex incoming encoded video 
and audio into a webm live stream. It is only used from 
content's MediaRecorderHandler.

This CL moves WebmMuxer to media/muxers where it 
belongs, since it has nothing to do with capture/; that is 
made even more relevant in a parallel CL
(http://crrev.com/1699553002) that isolates the said
media/capture.

This CL doesn't modify code (except a minor style 
reformatting caught by the presubmit). Narrowed some
DEPS too.

BUG=584797
==========

[mcasas, 2016-02-18 18:43:46]

Patchset #2 (id:20001) has been deleted

[mcasas, 2016-02-18 18:46:04]

Patchset #2 (id:40001) has been deleted

[DaleCurtis, 2016-02-18 18:52:07]

lgtm

[mcasas, 2016-02-18 19:00:56]

The CQ bit was checked by mcasas@chromium.org

[commit-bot: I haz the power, 2016-02-18 19:05:53]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1710713002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1710713002/60001

[commit-bot: I haz the power, 2016-02-18 20:11:44]

Description was changed from

==========
Move media/capture/webm_muxer* to media/muxers

WebmMuxer is used to multiplex incoming encoded video 
and audio into a webm live stream. It is only used from 
content's MediaRecorderHandler.

This CL moves WebmMuxer to media/muxers where it 
belongs, since it has nothing to do with capture/; that is 
made even more relevant in a parallel CL
(http://crrev.com/1699553002) that isolates the said
media/capture.

This CL doesn't modify code (except a minor style 
reformatting caught by the presubmit). Narrowed some
DEPS too.

BUG=584797
==========

to

==========
Move media/capture/webm_muxer* to media/muxers

WebmMuxer is used to multiplex incoming encoded video 
and audio into a webm live stream. It is only used from 
content's MediaRecorderHandler.

This CL moves WebmMuxer to media/muxers where it 
belongs, since it has nothing to do with capture/; that is 
made even more relevant in a parallel CL
(http://crrev.com/1699553002) that isolates the said
media/capture.

This CL doesn't modify code (except a minor style 
reformatting caught by the presubmit). Narrowed some
DEPS too.

BUG=584797
==========

[commit-bot: I haz the power, 2016-02-18 20:11:46]

Committed patchset #2 (id:60001)

[commit-bot: I haz the power, 2016-02-18 20:13:04]

Description was changed from

==========
Move media/capture/webm_muxer* to media/muxers

WebmMuxer is used to multiplex incoming encoded video 
and audio into a webm live stream. It is only used from 
content's MediaRecorderHandler.

This CL moves WebmMuxer to media/muxers where it 
belongs, since it has nothing to do with capture/; that is 
made even more relevant in a parallel CL
(http://crrev.com/1699553002) that isolates the said
media/capture.

This CL doesn't modify code (except a minor style 
reformatting caught by the presubmit). Narrowed some
DEPS too.

BUG=584797
==========

to

==========
Move media/capture/webm_muxer* to media/muxers

WebmMuxer is used to multiplex incoming encoded video
and audio into a webm live stream. It is only used from
content's MediaRecorderHandler.

This CL moves WebmMuxer to media/muxers where it
belongs, since it has nothing to do with capture/; that is
made even more relevant in a parallel CL
(http://crrev.com/1699553002) that isolates the said
media/capture.

This CL doesn't modify code (except a minor style
reformatting caught by the presubmit). Narrowed some
DEPS too.

BUG=584797

Committed: https://crrev.com/7db2a519b8121924ae9b86599e493a0fd68ad4ea
Cr-Commit-Position: refs/heads/master@{#376243}
==========

[commit-bot: I haz the power, 2016-02-18 20:13:05]

Patchset 2 (id:??) landed as
https://crrev.com/7db2a519b8121924ae9b86599e493a0fd68ad4ea
Cr-Commit-Position: refs/heads/master@{#376243}