MD Settings: remove previous team members from OWNERS

MD Settings: remove previous team members from OWNERS

BUG=388460
Committed: https://crrev.com/660aa300e54ecab48bf14c5932441d22d7a9ca46
Cr-Commit-Position: refs/heads/master@{#376094}

[michaelpg, 2016-02-17 23:43:07]

Description was changed from

==========
MD Settings: replace previous team members with new team members in OWNERSes
==========

to

==========
MD Settings: replace previous team members with new team members in OWNERSes

BUG=388460
==========

[michaelpg, 2016-02-17 23:44:11]

Patchset #1 (id:1) has been deleted

[michaelpg, 2016-02-17 23:44:35]

michaelpg@chromium.org changed reviewers:
+ dbeam@chromium.org, stevenjb@chromium.org

[michaelpg, 2016-02-17 23:44:35]

michaelpg@chromium.org changed required reviewers:
+ dbeam@chromium.org, stevenjb@chromium.org

[stevenjb, 2016-02-17 23:45:47]

lgtm

[Dan Beam, 2016-02-17 23:52:52]

ehhhhhhhh, i'd just remove orenb@ rather than add me

you're welcome to do whatever you'd like, but I don't want to be an OWNER of
code I don't know well

[michaelpg, 2016-02-17 23:56:46]

On 2016/02/17 23:52:52, Dan Beam wrote:
> ehhhhhhhh, i'd just remove orenb@ rather than add me
> 
> you're welcome to do whatever you'd like, but I don't want to be an OWNER of
> code I don't know well

nobody knows it well. the point is to have someone other than stevenjb to
approve changes

I can swap it to myself, but neither myself nor steven will be maintaining
non-cros settings forever.

[Dan Beam, 2016-02-18 00:08:00]

On 2016/02/17 23:56:46, michaelpg wrote:
> On 2016/02/17 23:52:52, Dan Beam wrote:
> > ehhhhhhhh, i'd just remove orenb@ rather than add me
> > 
> > you're welcome to do whatever you'd like, but I don't want to be an OWNER of
> > code I don't know well
> 
> nobody knows it well. the point is to have someone other than stevenjb to
> approve changes

there's plenty of folks in chrome/browser/extensions/OWNERS and
chrome/browser/chromeos/extensions/OWNERS that are more qualified than me and
already own the code, as far as I can tell ;)

> 
> I can swap it to myself, but neither myself nor steven will be maintaining
> non-cros settings forever.

[michaelpg, 2016-02-18 00:09:47]

On Wed, Feb 17, 2016 at 4:08 PM <dbeam@chromium.org> wrote:

> On 2016/02/17 23:56:46, michaelpg wrote:
> > On 2016/02/17 23:52:52, Dan Beam wrote:
> > > ehhhhhhhh, i'd just remove orenb@
>
>  rather than add me
> > >
> > > you're welcome to do whatever you'd like, but I don't want to be an OWNER
of
> > > code I don't know well
> >
> > nobody knows it well. the point is to have someone other than stevenjb to
> > approve changes
>
> there's plenty of folks in chrome/browser/extensions/OWNERS and
> chrome/browser/chromeos/extensions/OWNERS that are more qualified than me and
> already own the code, as far as I can tell ;)
>
> the OWNERS file existing encourages people to use that owner. are you
suggesting we just delete the OWNERS files we don't want to be in, so
extension owners are the default owners?

> >
> > I can swap it to myself, but neither myself nor steven will be maintaining
> > non-cros settings forever.
> https://codereview.chromium.org/1710673002/
>
>

-- 
You received this message because you are subscribed to the Google Groups
"Chromium-reviews" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[Dan Beam, 2016-02-18 00:12:18]

On 2016/02/18 00:09:47, michaelpg wrote:
> On Wed, Feb 17, 2016 at 4:08 PM <mailto:dbeam@chromium.org> wrote:
> 
> > On 2016/02/17 23:56:46, michaelpg wrote:
> > > On 2016/02/17 23:52:52, Dan Beam wrote:
> > > > ehhhhhhhh, i'd just remove orenb@
> >
> >  rather than add me
> > > >
> > > > you're welcome to do whatever you'd like, but I don't want to be an
OWNER
> of
> > > > code I don't know well
> > >
> > > nobody knows it well. the point is to have someone other than stevenjb to
> > > approve changes
> >
> > there's plenty of folks in chrome/browser/extensions/OWNERS and
> > chrome/browser/chromeos/extensions/OWNERS that are more qualified than me
and
> > already own the code, as far as I can tell ;)
> >
> > the OWNERS file existing encourages people to use that owner. are you
> suggesting we just delete the OWNERS files we don't want to be in, so
> extension owners are the default owners?

i'm recommending you find the best people to review the change
http://www.chromium.org/developers/owners-files

[michaelpg, 2016-02-18 04:05:06]

Description was changed from

==========
MD Settings: replace previous team members with new team members in OWNERSes

BUG=388460
==========

to

==========
MD Settings: remove previous team members from OWNERS

BUG=388460
==========

[michaelpg, 2016-02-18 04:05:26]

michaelpg@chromium.org changed required reviewers:
- dbeam@chromium.org

[michaelpg, 2016-02-18 04:06:08]

found better owners...

[michaelpg, 2016-02-18 04:06:11]

The CQ bit was checked by michaelpg@chromium.org

[michaelpg, 2016-02-18 04:06:11]

The patchset sent to the CQ was uploaded after l-g-t-m from
stevenjb@chromium.org
Link to the patchset: https://codereview.chromium.org/1710673002/#ps40001
(title: "remove dbeam")

[commit-bot: I haz the power, 2016-02-18 04:06:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1710673002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1710673002/40001

[commit-bot: I haz the power, 2016-02-18 04:38:08]

Description was changed from

==========
MD Settings: remove previous team members from OWNERS

BUG=388460
==========

to

==========
MD Settings: remove previous team members from OWNERS

BUG=388460
==========

[commit-bot: I haz the power, 2016-02-18 04:38:09]

Committed patchset #2 (id:40001)

[commit-bot: I haz the power, 2016-02-18 04:39:23]

Description was changed from

==========
MD Settings: remove previous team members from OWNERS

BUG=388460
==========

to

==========
MD Settings: remove previous team members from OWNERS

BUG=388460

Committed: https://crrev.com/660aa300e54ecab48bf14c5932441d22d7a9ca46
Cr-Commit-Position: refs/heads/master@{#376094}
==========

[commit-bot: I haz the power, 2016-02-18 04:39:24]

Patchset 2 (id:??) landed as
https://crrev.com/660aa300e54ecab48bf14c5932441d22d7a9ca46
Cr-Commit-Position: refs/heads/master@{#376094}