Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
1710663002:
GN: Remove redundant -m32 flag from nacl glibc x86 compiler (Closed)
DescriptionGN: Remove redundant -m32 flag from nacl glibc x86 compiler
This a followup to https://codereview.chromium.org/1693913002
which added the -m32 unnecessarily (since :compiler_cpu_abi
already adds it).
Committed: https://crrev.com/1ead906447157a8640d449e7d85275f161191dff
Cr-Commit-Position: refs/heads/master@{#376061}
Patch Set 1 #
Total comments: 2
Patch Set 2 : #Messages
Total messages: 19 (7 generated)
The CQ bit was checked by sbc@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710663002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710663002/1
sbc@chromium.org changed reviewers: + dpranke@chromium.org, mcgrathr@chromium.org
lgtm with one comment typo. https://codereview.chromium.org/1710663002/diff/1/build/toolchain/nacl/BUILD.gn File build/toolchain/nacl/BUILD.gn (right): https://codereview.chromium.org/1710663002/diff/1/build/toolchain/nacl/BUILD.... build/toolchain/nacl/BUILD.gn:152: # currently in goma) Missing period at end of sentence.
The CQ bit was checked by sbc@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from mcgrathr@chromium.org Link to the patchset: https://codereview.chromium.org/1710663002/#ps20001 (title: " ")
https://codereview.chromium.org/1710663002/diff/1/build/toolchain/nacl/BUILD.gn File build/toolchain/nacl/BUILD.gn (right): https://codereview.chromium.org/1710663002/diff/1/build/toolchain/nacl/BUILD.... build/toolchain/nacl/BUILD.gn:152: # currently in goma) On 2016/02/17 23:54:17, Roland McGrath wrote: > Missing period at end of sentence. Done.
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710663002/20001
I admit that I'm kinda lost here. If this CL breaks my goma win compile, I'll come back to one of you to explain how we fix that :).
On 2016/02/18 00:08:54, Dirk Pranke wrote: > I admit that I'm kinda lost here. If this CL breaks my goma win compile, I'll > come back to one of you to explain how we fix that :). The previous CL fixed that, but resulted in "x86_64-nacl-gcc -m32 ... -m32 ...", which is correct but redundant. This CL fixes it so it will just do "x86_64-nacl-gcc ... -m32 ..." like the native gcc and clang toolchains for Linux/Mac do.
The CQ bit was unchecked by commit-bot@chromium.org
Try jobs failed on following builders: chromium_presubmit on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)
lgtm
The CQ bit was checked by sbc@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710663002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710663002/20001
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== GN: Remove redundant -m32 flag from nacl glibc x86 compiler This a followup to https://codereview.chromium.org/1693913002 which added the -m32 unnecessarily (since :compiler_cpu_abi already adds it). ========== to ========== GN: Remove redundant -m32 flag from nacl glibc x86 compiler This a followup to https://codereview.chromium.org/1693913002 which added the -m32 unnecessarily (since :compiler_cpu_abi already adds it). Committed: https://crrev.com/1ead906447157a8640d449e7d85275f161191dff Cr-Commit-Position: refs/heads/master@{#376061} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/1ead906447157a8640d449e7d85275f161191dff Cr-Commit-Position: refs/heads/master@{#376061} |
