Prevent creation of the GnubbyExtension if no socket name is defined.

Prevent creation of the GnubbyExtension if no socket name is defined.

This change fixes a DCHECK on linux when the host is run without specifying
a socket name.  Typically the host has a name passed in as an argument
however it is not required and may be skipped for a number of reasons.

The fix here is to skip the creation of the GnubbyExtension if a socket
name is not passed in.  The net effect of this is that if a CRD client
passes a gnubby-auth extension message, the ClientSession will look for
a registered extension to handle the message (which won't exist) and the
message will be ignored.

BUG=587622
Committed: https://crrev.com/1002bde384f0a529949d2861b947110af0f91929
Cr-Commit-Position: refs/heads/master@{#376079}

[joedow, 2016-02-17 23:35:28]

joedow@chromium.org changed reviewers:
+ lambroslambrou@chromium.org

[joedow, 2016-02-17 23:35:28]

PTAL!

[Lambros, 2016-02-18 01:02:39]

lgtm

https://codereview.chromium.org/1710653002/diff/1/remoting/host/remoting_me2m...
File remoting/host/remoting_me2me_host.cc (right):

https://codereview.chromium.org/1710653002/diff/1/remoting/host/remoting_me2m...
remoting/host/remoting_me2me_host.cc:431: bool skip_gnubby_extension_creation_;
Optional: Maybe better to invert the meaning and call it
enable_gnubby_extension_ ? Default-initialize to false and set it to true when
the socket name is provided?

[joedow, 2016-02-18 02:24:37]

Thanks!

https://codereview.chromium.org/1710653002/diff/1/remoting/host/remoting_me2m...
File remoting/host/remoting_me2me_host.cc (right):

https://codereview.chromium.org/1710653002/diff/1/remoting/host/remoting_me2m...
remoting/host/remoting_me2me_host.cc:431: bool skip_gnubby_extension_creation_;
On 2016/02/18 01:02:39, Lambros wrote:
> Optional: Maybe better to invert the meaning and call it
> enable_gnubby_extension_ ? Default-initialize to false and set it to true when
> the socket name is provided?

That's a good point, I was originally thinking I would create the extension for
the other OS's but that doesn't work at this point so I've flipped the flag and
we now only create the extension on Linux and only if the socket name has been
passed in to us.

[joedow, 2016-02-18 02:24:37]

Thanks!

[joedow, 2016-02-18 02:24:42]

The CQ bit was checked by joedow@chromium.org

[joedow, 2016-02-18 02:24:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
lambroslambrou@chromium.org
Link to the patchset: https://codereview.chromium.org/1710653002/#ps20001
(title: "Updating flag usage for enabling extension creation")

[commit-bot: I haz the power, 2016-02-18 02:25:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1710653002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1710653002/20001

[commit-bot: I haz the power, 2016-02-18 02:57:25]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-18 02:58:38]

Description was changed from

==========
Prevent creation of the GnubbyExtension if no socket name is defined.

This change fixes a DCHECK on linux when the host is run without specifying
a socket name.  Typically the host has a name passed in as an argument
however it is not required and may be skipped for a number of reasons.

The fix here is to skip the creation of the GnubbyExtension if a socket
name is not passed in.  The net effect of this is that if a CRD client
passes a gnubby-auth extension message, the ClientSession will look for
a registered extension to handle the message (which won't exist) and the
message will be ignored.

BUG=587622
==========

to

==========
Prevent creation of the GnubbyExtension if no socket name is defined.

This change fixes a DCHECK on linux when the host is run without specifying
a socket name.  Typically the host has a name passed in as an argument
however it is not required and may be skipped for a number of reasons.

The fix here is to skip the creation of the GnubbyExtension if a socket
name is not passed in.  The net effect of this is that if a CRD client
passes a gnubby-auth extension message, the ClientSession will look for
a registered extension to handle the message (which won't exist) and the
message will be ignored.

BUG=587622

Committed: https://crrev.com/1002bde384f0a529949d2861b947110af0f91929
Cr-Commit-Position: refs/heads/master@{#376079}
==========

[commit-bot: I haz the power, 2016-02-18 02:58:38]

Patchset 2 (id:??) landed as
https://crrev.com/1002bde384f0a529949d2861b947110af0f91929
Cr-Commit-Position: refs/heads/master@{#376079}