Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(418)

Unified Diff: lib/runtime/dart/_internal.js

Issue 1710583002: Fix tests (Closed) Base URL: https://github.com/dart-lang/dev_compiler.git@master
Patch Set: Fix hints and reformat Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | lib/runtime/dart/async.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: lib/runtime/dart/_internal.js
diff --git a/lib/runtime/dart/_internal.js b/lib/runtime/dart/_internal.js
index f773eb973799d570a089415a7dd3b8b319d9a344..22f9e8b9813e1b676f3c0061c32d2aa4b18d2c04 100644
--- a/lib/runtime/dart/_internal.js
+++ b/lib/runtime/dart/_internal.js
@@ -1095,27 +1095,23 @@ dart_library.library('dart/_internal', null, /* Imports */[
return false;
}
static forEach(iterable, f) {
- dart.as(f, dart.functionType(dart.void, [dart.dynamic]));
for (let e of iterable) {
f(e);
}
}
static any(iterable, f) {
- dart.as(f, dart.functionType(core.bool, [dart.dynamic]));
for (let e of iterable) {
if (dart.notNull(f(e))) return true;
}
return false;
}
static every(iterable, f) {
- dart.as(f, dart.functionType(core.bool, [dart.dynamic]));
for (let e of iterable) {
if (!dart.notNull(f(e))) return false;
}
return true;
}
static reduce(iterable, combine) {
- dart.as(combine, dart.functionType(dart.dynamic, [dart.dynamic, dart.dynamic]));
let iterator = iterable[dartx.iterator];
if (!dart.notNull(iterator.moveNext())) dart.throw(IterableElementError.noElement());
let value = iterator.current;
@@ -1125,14 +1121,12 @@ dart_library.library('dart/_internal', null, /* Imports */[
return value;
}
static fold(iterable, initialValue, combine) {
- dart.as(combine, dart.functionType(dart.dynamic, [dart.dynamic, dart.dynamic]));
for (let element of iterable) {
initialValue = combine(initialValue, element);
}
return initialValue;
}
static removeWhereList(list, test) {
- dart.as(test, dart.functionType(core.bool, [dart.dynamic]));
let retained = dart.list([], dart.dynamic);
let length = list[dartx.length];
for (let i = 0; i < dart.notNull(length); i++) {
@@ -1179,8 +1173,6 @@ dart_library.library('dart/_internal', null, /* Imports */[
return result;
}
static firstWhere(iterable, test, orElse) {
- dart.as(test, dart.functionType(core.bool, [dart.dynamic]));
- dart.as(orElse, dart.functionType(dart.dynamic, []));
for (let element of iterable) {
if (dart.notNull(test(element))) return element;
}
@@ -1188,8 +1180,6 @@ dart_library.library('dart/_internal', null, /* Imports */[
dart.throw(IterableElementError.noElement());
}
static lastWhere(iterable, test, orElse) {
- dart.as(test, dart.functionType(core.bool, [dart.dynamic]));
- dart.as(orElse, dart.functionType(dart.dynamic, []));
let result = null;
let foundMatching = false;
for (let element of iterable) {
@@ -1203,8 +1193,6 @@ dart_library.library('dart/_internal', null, /* Imports */[
dart.throw(IterableElementError.noElement());
}
static lastWhereList(list, test, orElse) {
- dart.as(test, dart.functionType(core.bool, [dart.dynamic]));
- dart.as(orElse, dart.functionType(dart.dynamic, []));
for (let i = dart.notNull(list[dartx.length]) - 1; i >= 0; i--) {
let element = list[dartx.get](i);
if (dart.notNull(test(element))) return element;
@@ -1213,7 +1201,6 @@ dart_library.library('dart/_internal', null, /* Imports */[
dart.throw(IterableElementError.noElement());
}
static singleWhere(iterable, test) {
- dart.as(test, dart.functionType(core.bool, [dart.dynamic]));
let result = null;
let foundMatching = false;
for (let element of iterable) {
@@ -1268,15 +1255,12 @@ dart_library.library('dart/_internal', null, /* Imports */[
return new (WhereIterable$(T))(iterable, f);
}
static map(iterable, f) {
- dart.as(f, dart.functionType(dart.dynamic, [dart.dynamic]));
return MappedIterable.new(iterable, f);
}
static mapList(list, f) {
- dart.as(f, dart.functionType(dart.dynamic, [dart.dynamic]));
return new MappedListIterable(list, f);
}
static expand(iterable, f) {
- dart.as(f, dart.functionType(core.Iterable, [dart.dynamic]));
return new ExpandIterable(iterable, f);
}
takeList(list, n) {
@@ -1297,7 +1281,6 @@ dart_library.library('dart/_internal', null, /* Imports */[
return new (ReversedListIterable$(T))(dart.as(list, core.Iterable$(T)));
}
static sortList(list, compare) {
- dart.as(compare, dart.functionType(core.int, [dart.dynamic, dart.dynamic]));
if (compare == null) compare = core.Comparable.compare;
Sort.sort(list, compare);
}
« no previous file with comments | « no previous file | lib/runtime/dart/async.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698