Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(72)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1710583002: Fix tests (Closed)

Created:
4 years, 10 months ago by vsm
Modified:
4 years, 10 months ago
Reviewers:
Jennifer Messerly
CC:
dev-compiler+reviews_dartlang.org
Base URL:
https://github.com/dart-lang/dev_compiler.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Fix travis This also regens based on the latest analyzer. Looks like most improvements on the code. See #456 TBR=jmesserly@google.com Committed: https://github.com/dart-lang/dev_compiler/commit/fa56ebbf11722eef0b9d3c4e5ebc4a8176afe1b9

Patch Set 1 #

Patch Set 2 : Fix hints and reformat #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -155 lines) Patch
M lib/runtime/dart/_internal.js View 8 chunks +0 lines, -17 lines 0 comments Download
M lib/runtime/dart/async.js View 14 chunks +14 lines, -45 lines 0 comments Download
M lib/runtime/dart/collection.js View 9 chunks +9 lines, -11 lines 0 comments Download
M lib/runtime/dart/js.js View 2 chunks +1 line, -6 lines 0 comments Download
M lib/src/codegen/assignments_index.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M lib/src/codegen/ast_builder.dart View 1 1 chunk +2 lines, -1 line 0 comments Download
M lib/src/codegen/js_codegen.dart View 1 7 chunks +24 lines, -24 lines 0 comments Download
M lib/src/codegen/nullability_inferrer.dart View 1 1 chunk +1 line, -2 lines 0 comments Download
M test/browser/language_tests.js View 1 chunk +3 lines, -1 line 0 comments Download
M test/codegen/expect/collection/src/equality.txt View 1 chunk +6 lines, -6 lines 0 comments Download
M test/codegen/expect/collection/src/priority_queue.js View 1 chunk +1 line, -1 line 0 comments Download
M test/codegen/expect/collection/src/priority_queue.txt View 1 chunk +0 lines, -1 line 0 comments Download
M test/codegen/expect/collection/src/queue_list.txt View 1 chunk +1 line, -0 lines 0 comments Download
M test/codegen/expect/collection/src/unmodifiable_wrappers.txt View 1 chunk +2 lines, -2 lines 0 comments Download
M test/codegen/expect/collection/src/wrappers.txt View 1 chunk +10 lines, -6 lines 0 comments Download
M test/codegen/expect/language-all.js View Binary file 0 comments Download
M tool/sdk_expected_errors.txt View 13 chunks +9 lines, -31 lines 0 comments Download

Messages

Total messages: 5 (3 generated)
vsm
Committed patchset #2 (id:20001) manually as fa56ebbf11722eef0b9d3c4e5ebc4a8176afe1b9 (presubmit successful).
4 years, 10 months ago (2016-02-17 21:13:05 UTC) #4
Jennifer Messerly
4 years, 10 months ago (2016-02-17 21:15:33 UTC) #5
Message was sent while issue was closed. 
LGTM. Some of those improvements are not sound, BTW. :)

It is a result of improved LUB. We have LUB for function types now, but not a
sound one.

Powered by Google App Engine
This is Rietveld 408576698