Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Issue 1710553003: Convert old-style exception handling to current format in fix_encoding.py. (Closed)

Created:
4 years, 10 months ago by M-A Ruel
Modified:
4 years, 10 months ago
Reviewers:
vapier
CC:
chromium-reviews, dpranke+depot_tools_chromium.org, iannucci+depot_tools_chromium.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Convert old-style exception handling to current format in fix_encoding.py. With this change, fix_encoding can be imported in python3. fix_encoding.fix_encoding() returns False because, at least on my Ubuntu 14.04 system running python 3.4.3; sys.getdefaultencoding() == 'utf-8' The Windows specific code hasn't been tested on python3 and is expected to require fixes. R=vapier@chromium.org BUG=61357 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=298834

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -5 lines) Patch
M fix_encoding.py View 5 chunks +5 lines, -5 lines 0 comments Download

Messages

Total messages: 8 (4 generated)
M-A Ruel
4 years, 10 months ago (2016-02-17 23:13:33 UTC) #1
vapier
lgtm
4 years, 10 months ago (2016-02-17 23:15:44 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710553003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710553003/1
4 years, 10 months ago (2016-02-17 23:17:04 UTC) #6
commit-bot: I haz the power
4 years, 10 months ago (2016-02-17 23:19:36 UTC) #8
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
http://src.chromium.org/viewvc/chrome?view=rev&revision=298834

Powered by Google App Engine
This is Rietveld 408576698