Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(293)

Issue 1710543002: Fix tests with Xcode 7. (Closed)

Created:
4 years, 10 months ago by justincohen
Modified:
4 years, 10 months ago
Reviewers:
sdefresne
CC:
gyp-developer_googlegroups.com
Base URL:
https://chromium.googlesource.com/external/gyp.git@master
Target Ref:
refs/heads/master
Project:
gyp
Visibility:
Public.

Description

Fix tests with Xcode 7. Xcode 7 prints "Beginning test session" to STDERR. Also removes xcode-ninja test from xcode gcc test. BUG= R=sdefresne@chromium.org Committed: https://chromium.googlesource.com/external/gyp/+/d84fed246cd42612c31a56a897e2d032e254a58a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -1 line) Patch
M test/lib/TestGyp.py View 1 chunk +2 lines, -1 line 0 comments Download
M test/mac/gyptest-xcode-gcc.py View 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
justincohen
PTAL!
4 years, 10 months ago (2016-02-17 19:47:52 UTC) #2
sdefresne
lgtm
4 years, 10 months ago (2016-02-18 08:17:13 UTC) #3
justincohen
4 years, 10 months ago (2016-02-18 16:56:50 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
d84fed246cd42612c31a56a897e2d032e254a58a (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698