Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(134)

Issue 171053002: Move ChromeOS only strings to chromeos_strings.grd (Closed)

Created:
6 years, 10 months ago by aurimas (slooooooooow)
Modified:
6 years, 10 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Move ChromeOS only strings to chromeos_strings.grd BUG=326023 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=252657

Patch Set 1 #

Patch Set 2 : Rebase #

Patch Set 3 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+313 lines, -322 lines) Patch
chrome/app/chromeos_strings.grdp View 1 2 1 chunk +308 lines, -0 lines 0 comments Download
chrome/app/generated_resources.grd View 1 2 5 chunks +5 lines, -322 lines 0 comments Download

Messages

Total messages: 23 (0 generated)
aurimas (slooooooooow)
Hey Newton, Please take a look at this change. Thanks, Aurimas
6 years, 10 months ago (2014-02-20 22:36:53 UTC) #1
newt (away)
lgtm
6 years, 10 months ago (2014-02-20 23:11:35 UTC) #2
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-20 23:21:18 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/171053002/1
6 years, 10 months ago (2014-02-20 23:21:59 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-20 23:22:02 UTC) #5
commit-bot: I haz the power
Failed to apply patch for chrome/app/generated_resources.grd: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-20 23:22:02 UTC) #6
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-21 01:35:43 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/171053002/110002
6 years, 10 months ago (2014-02-21 01:37:22 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 02:42:06 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) interactive_ui_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=267544
6 years, 10 months ago (2014-02-21 02:42:07 UTC) #10
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-21 16:35:57 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/171053002/110002
6 years, 10 months ago (2014-02-21 16:36:42 UTC) #12
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 16:36:44 UTC) #13
commit-bot: I haz the power
Failed to apply patch for chrome/app/chromeos_strings.grdp: While running patch -p1 --forward --force --no-backup-if-mismatch; patching file ...
6 years, 10 months ago (2014-02-21 16:36:44 UTC) #14
aurimas (slooooooooow)
The CQ bit was checked by aurimas@chromium.org
6 years, 10 months ago (2014-02-21 16:46:03 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/171053002/420001
6 years, 10 months ago (2014-02-21 16:46:44 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 18:23:30 UTC) #17
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-21 18:23:31 UTC) #18
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-21 18:23:41 UTC) #19
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 10 months ago (2014-02-21 18:23:41 UTC) #20
Sergey Berezin
The CQ bit was checked by sergeyberezin@chromium.org
6 years, 10 months ago (2014-02-21 19:57:46 UTC) #21
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/171053002/420001
6 years, 10 months ago (2014-02-21 20:00:20 UTC) #22
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 21:54:33 UTC) #23
Message was sent while issue was closed.
Change committed as 252657

Powered by Google App Engine
This is Rietveld 408576698