runtime/vm/virtual_memory_win.cc - Issue 1710443003: Fix background compilation: allocate stubs at safepoint

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/virtual_memory_win.cc

Issue 1710443003: Fix background compilation: allocate stubs at safepoint (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: d Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/virtual_memory_win.cc

diff --git a/runtime/vm/virtual_memory_win.cc b/runtime/vm/virtual_memory_win.cc

index dd154ac1c0fbdcaa0982ac82d5e4248f31a4ac21..7f1a6263bdab7143da2dcb2438b96a97b15467ca 100644

--- a/runtime/vm/virtual_memory_win.cc

+++ b/runtime/vm/virtual_memory_win.cc

@@ -63,6 +63,8 @@ bool VirtualMemory::Commit(uword addr, intptr_t size, bool executable) {

bool VirtualMemory::Protect(void* address, intptr_t size, Protection mode) {

+ ASSERT(Thread::Current()->IsMutatorThread() ||

+ Isolate::Current()->mutator_thread()->IsAtSafepoint());

uword start_address = reinterpret_cast<uword>(address);

uword end_address = start_address + size;

uword page_address = Utils::RoundDown(start_address, PageSize());