chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java - Issue 1710443002: bluetooth: Add URLs for Web Bluetooth help links.

Unified Diff: chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

Issue 1710443002: bluetooth: Add URLs for Web Bluetooth help links. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Moar comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/android/java/src/org/chromium/chrome/browser/ItemChooserDialog.java ('K') | « chrome/android/java/strings/android_chrome_strings.grd ('k') | chrome/browser/ui/android/bluetooth_chooser_android.h » ('j') | chrome/browser/ui/android/bluetooth_chooser_android.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

index d1f1df81f8433b96a5a059704ed7484f766993f8..e4b0618b79763c42a3f10ad8c3f8b0e5fba3a391 100644

--- a/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

+++ b/chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java

@@ -59,13 +59,15 @@ public class ItemChooserDialogTest extends ChromeActivityTestCaseBase<ChromeActi

private ItemChooserDialog createDialog() {

SpannableString title = new SpannableString("title");

- String searching = new String("searching");

+ SpannableString searching = new SpannableString("searching");

SpannableString noneFound = new SpannableString("noneFound");

SpannableString statusActive = new SpannableString("statusActive");

- SpannableString statusIdle = new SpannableString("statusIdle");

+ SpannableString statusIdleNoneFound = new SpannableString("statusIdleNoneFound");

+ SpannableString statusIdleSomeFound = new SpannableString("statusIdleSomeFound");

String positiveButton = new String("positiveButton");

- final ItemChooserDialog.ItemChooserLabels labels = new ItemChooserDialog.ItemChooserLabels(

- title, searching, noneFound, statusActive, statusIdle, positiveButton);

+ final ItemChooserDialog.ItemChooserLabels labels =

+ new ItemChooserDialog.ItemChooserLabels(title, searching, noneFound, statusActive,

+ statusIdleNoneFound, statusIdleSomeFound, positiveButton);

ItemChooserDialog dialog = ThreadUtils.runOnUiThreadBlockingNoException(

new Callable<ItemChooserDialog>() {

@Override

@@ -147,7 +149,7 @@ public class ItemChooserDialogTest extends ChromeActivityTestCaseBase<ChromeActi

// The chooser should show the status idle text.

assertEquals(View.VISIBLE, items.getVisibility());

assertEquals(View.GONE, items.getEmptyView().getVisibility());

- assertEquals("statusIdle", statusView.getText().toString());

+ assertEquals("statusIdleSomeFound", statusView.getText().toString());

assertFalse(button.isEnabled());

// Select the first item and verify it got selected.

@@ -178,7 +180,7 @@ public class ItemChooserDialogTest extends ChromeActivityTestCaseBase<ChromeActi

// drive home the point and a status message at the bottom.

assertEquals(View.GONE, items.getVisibility());

assertEquals(View.VISIBLE, items.getEmptyView().getVisibility());

- assertEquals("statusIdle", statusView.getText().toString());

+ assertEquals("statusIdleNoneFound", statusView.getText().toString());

assertFalse(button.isEnabled());

mChooserDialog.dismiss();