chrome/browser/ui/android/bluetooth_chooser_android.h - Issue 1710443002: bluetooth: Add URLs for Web Bluetooth help links.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/android/bluetooth_chooser_android.h

Issue 1710443002: bluetooth: Add URLs for Web Bluetooth help links. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@my-origin

Patch Set: Address tedchoc's comments Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/android/javatests/src/org/chromium/chrome/browser/ItemChooserDialogTest.java ('k') | chrome/browser/ui/android/bluetooth_chooser_android.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/android/bluetooth_chooser_android.h

diff --git a/chrome/browser/ui/android/bluetooth_chooser_android.h b/chrome/browser/ui/android/bluetooth_chooser_android.h

index d090c9e55381f3cce122110985fa4651faf5a6df..fc77e636cb3d9cae617fec364445a051b6764bb1 100644

--- a/chrome/browser/ui/android/bluetooth_chooser_android.h

+++ b/chrome/browser/ui/android/bluetooth_chooser_android.h

@@ -17,6 +17,7 @@ class Origin;

// options.

class BluetoothChooserAndroid : public content::BluetoothChooser {

public:

+ // Both frame and event_handler must outlive the BluetoothChooserAndroid.

BluetoothChooserAndroid(content::RenderFrameHost* frame,

const EventHandler& event_handler);

~BluetoothChooserAndroid() override;

@@ -42,9 +43,6 @@ class BluetoothChooserAndroid : public content::BluetoothChooser {

void ShowBluetoothOverviewLink(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj);

- void ShowBluetoothPairingLink(

- JNIEnv* env,

- const base::android::JavaParamRef<jobject>& obj);

void ShowBluetoothAdapterOffLink(

JNIEnv* env,

const base::android::JavaParamRef<jobject>& obj);

@@ -55,8 +53,10 @@ class BluetoothChooserAndroid : public content::BluetoothChooser {

static bool Register(JNIEnv* env);

private:

+ void OpenURL(const char* url);

base::android::ScopedJavaGlobalRef<jobject> java_dialog_;

+ content::WebContents* web_contents_;

BluetoothChooser::EventHandler event_handler_;

};