bluetooth: Add URLs for Web Bluetooth help links.

chrome/browser/ui/android/bluetooth_chooser_android.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/android/bluetooth_chooser_android.h"
 
 #include "base/android/jni_android.h"
 #include "base/android/jni_string.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/ssl/chrome_security_state_model_client.h"
 #include "chrome/browser/ui/android/view_android_helper.h"
+#include "chrome/common/url_constants.h"
 #include "content/public/browser/android/content_view_core.h"
 #include "content/public/browser/render_frame_host.h"
 #include "jni/BluetoothChooserDialog_jni.h"
 #include "ui/android/window_android.h"
 #include "url/origin.h"
 
 using base::android::AttachCurrentThread;
 using base::android::ConvertUTF8ToJavaString;
 using base::android::ConvertUTF16ToJavaString;
 using base::android::ScopedJavaLocalRef;
 
 BluetoothChooserAndroid::BluetoothChooserAndroid(
     content::RenderFrameHost* frame,
     const EventHandler& event_handler)
-    : event_handler_(event_handler) {
+    : web_contents_(content::WebContents::FromRenderFrameHost(frame)),
+      event_handler_(event_handler) {
   const url::Origin origin = frame->GetLastCommittedOrigin();
   DCHECK(!origin.unique());
-  content::WebContents* web_contents =
-      content::WebContents::FromRenderFrameHost(frame);
+
   base::android::ScopedJavaLocalRef<jobject> window_android =
-      content::ContentViewCore::FromWebContents(
-          web_contents)->GetWindowAndroid()->GetJavaObject();
+      content::ContentViewCore::FromWebContents(web_contents_)
+          ->GetWindowAndroid()
+          ->GetJavaObject();
 
   ChromeSecurityStateModelClient* security_model_client =
-      ChromeSecurityStateModelClient::FromWebContents(web_contents);
+      ChromeSecurityStateModelClient::FromWebContents(web_contents_);
   DCHECK(security_model_client);
 
   // Create (and show) the BluetoothChooser dialog.
   JNIEnv* env = AttachCurrentThread();
   ScopedJavaLocalRef<jstring> origin_string =
       ConvertUTF8ToJavaString(env, origin.Serialize());
   java_dialog_.Reset(Java_BluetoothChooserDialog_create(
       env, window_android.obj(), origin_string.obj(),
       security_model_client->GetSecurityInfo().security_level,
       reinterpret_cast<intptr_t>(this)));
@@ skipping 79 matching lines @@
 }
 
 void BluetoothChooserAndroid::RestartSearch(JNIEnv* env,
                                             const JavaParamRef<jobject>& obj) {
   event_handler_.Run(Event::RESCAN, "");
 }
 
 void BluetoothChooserAndroid::ShowBluetoothOverviewLink(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj) {
+  OpenURL(chrome::kChooserBluetoothOverviewURL);
   event_handler_.Run(Event::SHOW_OVERVIEW_HELP, "");
 }
 
-void BluetoothChooserAndroid::ShowBluetoothPairingLink(
-    JNIEnv* env,
-    const JavaParamRef<jobject>& obj) {
-  event_handler_.Run(Event::SHOW_PAIRING_HELP, "");
-}
-
 void BluetoothChooserAndroid::ShowBluetoothAdapterOffLink(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj) {
+  OpenURL(chrome::kChooserBluetoothOverviewURL);
   event_handler_.Run(Event::SHOW_ADAPTER_OFF_HELP, "");
 }
 
 void BluetoothChooserAndroid::ShowNeedLocationPermissionLink(
     JNIEnv* env,
     const JavaParamRef<jobject>& obj) {
+  OpenURL(chrome::kChooserBluetoothOverviewURL);
   event_handler_.Run(Event::SHOW_NEED_LOCATION_HELP, "");
 }
 
 // static
 bool BluetoothChooserAndroid::Register(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
+
+void BluetoothChooserAndroid::OpenURL(const char* url) {
+  web_contents_->OpenURL(content::OpenURLParams(
+      GURL(url), content::Referrer(), NEW_FOREGROUND_TAB,
+      ui::PAGE_TRANSITION_AUTO_TOPLEVEL, false /* is_renderer_initiated */));

[Ted C, 2016/02/19 17:54:01]

Out of curiosity, what happens if the page that triggered the bluetooth
discovery dialog crashes/renderer dies?

In particular on svelte devices, there is a limit of one renderer so this will
pretty much guarantee the current one goes away.

Does the dialog get dismissed if you click the help link (probably covered by
the TODO in the other file)?

[ortuno, 2016/02/19 18:26:28]

Right now the dialog would stay on top. The issue in the TODO in
BluetoothChooserDialog.java is meant to fix cases like this.
It does get dismissed. Right now the event_handler closes the chooser when you
click the help link, but in the future we would want the chooser to be smart
enough to know that a navigation, new tab, crash, etc. means it should be
dismissed, in the same way the chrome_bubble_manager.cc does it for desktop
bubbles.

+}