Issue 171043: Stop shortening the Mac lproj directories (ie-"en-US" instead of "en")....

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 171043: Stop shortening the Mac lproj directories (ie-"en-US" instead of "en").... (Closed)

Created:
11 years, 4 months ago by TVL

Modified:
9 years, 7 months ago

Reviewers:
Mark Mentovai

CC:
chromium-reviews_googlegroups.com

Base URL:
svn://svn.chromium.org/chrome/trunk/src/

Visibility:
Public.

Description

Stop shortening the Mac lproj directories (ie-"en-US" instead of "en"). Add a script to make a link for "en.lproj" so we always have an english in the fall back list. Run said script as a postbuild step. TEST=Chrome should now show all 40 language when you do a get info in the finder. BUG=19165 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=23547

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+31 lines, -22 lines)			Patch
A	chrome/app/tweak_mac_lproj_folders	View	1	1 chunk	+22 lines, -0 lines	0 comments	Download
M	chrome/chrome.gyp	View	1 2 3 4	3 chunks	+8 lines, -18 lines	0 comments	Download
M	chrome/tools/build/repack_locales.py	View	1 2 3 4	1 chunk	+1 line, -4 lines	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Mark Mentovai

11 years, 4 months ago (2009-08-17 14:28:41 UTC) #2

LG otherwise

http://codereview.chromium.org/171043/diff/1/2
File chrome/app/tweak_mac_lproj_folders (right):

http://codereview.chromium.org/171043/diff/1/2#newcode9
Line 9: # vs. what Cocoa would like.
"sync" the verb takes "with," not "versus."

http://codereview.chromium.org/171043/diff/1/2#newcode17
Line 17: ln -fhs "en-US.lproj" "en.lproj"
Won't there be an en.lproj directory in old builds, in the same way that there's
a zh.lproj?  This will not do the right thing in that case.  I think you might
need to move the rm up above this, and make it apply to en.lproj and zh.lproj.

http://codereview.chromium.org/171043/diff/1/2#newcode20
Line 20: # (This can go away after about a week when it won't exist on the bots
or
Don't parenthesize.  TODO.  Provide a target date in the comment.

http://codereview.chromium.org/171043/diff/1/2#newcode21
Line 21: # developers local builds)
developers' (possessive)

Expand Messages | Collapse Messages