Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(846)

Issue 1710403003: Clean up WebTaskRunner::Task subclasses in web/tests/ (Closed)

Created:
4 years, 10 months ago by hiroshige
Modified:
4 years, 10 months ago
Reviewers:
kinuko, dcheng
CC:
blink-reviews, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Clean up WebTaskRunner::Task subclasses in web/tests/ BUG=478194 Committed: https://crrev.com/2882d59b5df13afe6e081828a32ce8ee54731b13 Cr-Commit-Position: refs/heads/master@{#376730}

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : #

Total comments: 2

Patch Set 6 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -25 lines) Patch
M third_party/WebKit/Source/web/tests/FrameTestHelpers.cpp View 1 2 3 4 2 chunks +15 lines, -25 lines 0 comments Download

Messages

Total messages: 37 (17 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/1
4 years, 10 months ago (2016-02-20 01:49:56 UTC) #2
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm64_dbg_recipe/builds/24660) linux_chromium_chromeos_ozone_rel_ng on ...
4 years, 10 months ago (2016-02-20 02:08:12 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/20001
4 years, 10 months ago (2016-02-20 02:16:44 UTC) #6
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/40001
4 years, 10 months ago (2016-02-20 02:22:29 UTC) #8
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-20 03:35:51 UTC) #10
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/80001
4 years, 10 months ago (2016-02-21 17:01:28 UTC) #13
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_compile_dbg_ng/builds/162283) mac_chromium_gn_rel on ...
4 years, 10 months ago (2016-02-21 17:03:24 UTC) #15
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/100001
4 years, 10 months ago (2016-02-21 18:08:41 UTC) #17
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-21 18:48:20 UTC) #19
hiroshige
PTAL.
4 years, 10 months ago (2016-02-21 18:57:29 UTC) #21
kinuko
+dcheng for owner review The postTask's in Web{View,Frame}Test are now gone, lgtm for FrameTestHelper.cpp change
4 years, 10 months ago (2016-02-22 04:31:51 UTC) #22
hiroshige
dcheng@, PTAL.
4 years, 10 months ago (2016-02-22 04:45:11 UTC) #24
dcheng
https://codereview.chromium.org/1710403003/diff/100001/third_party/WebKit/Source/web/tests/WebFrameTest.cpp File third_party/WebKit/Source/web/tests/WebFrameTest.cpp (left): https://codereview.chromium.org/1710403003/diff/100001/third_party/WebKit/Source/web/tests/WebFrameTest.cpp#oldcode3237 third_party/WebKit/Source/web/tests/WebFrameTest.cpp:3237: class ReloadWithOverrideURLTask : public WebTaskRunner::Task { I think kinuko@ ...
4 years, 10 months ago (2016-02-22 05:02:28 UTC) #25
hiroshige
Oh, I see. Rebased.
4 years, 10 months ago (2016-02-22 06:12:47 UTC) #27
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/120001
4 years, 10 months ago (2016-02-22 06:13:05 UTC) #28
dcheng
lgtm
4 years, 10 months ago (2016-02-22 07:01:37 UTC) #29
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-22 07:15:28 UTC) #31
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/120001
4 years, 10 months ago (2016-02-22 15:18:44 UTC) #34
commit-bot: I haz the power
Committed patchset #6 (id:120001)
4 years, 10 months ago (2016-02-22 15:25:59 UTC) #35
commit-bot: I haz the power
4 years, 10 months ago (2016-02-22 15:26:55 UTC) #37
Message was sent while issue was closed.
Patchset 6 (id:??) landed as
https://crrev.com/2882d59b5df13afe6e081828a32ce8ee54731b13
Cr-Commit-Position: refs/heads/master@{#376730}

Powered by Google App Engine
This is Rietveld 408576698