|
|
DescriptionClean up WebTaskRunner::Task subclasses in web/tests/
BUG=478194
Committed: https://crrev.com/2882d59b5df13afe6e081828a32ce8ee54731b13
Cr-Commit-Position: refs/heads/master@{#376730}
Patch Set 1 #Patch Set 2 : #Patch Set 3 : #Patch Set 4 : #Patch Set 5 : #
Total comments: 2
Patch Set 6 : Rebase #Messages
Total messages: 37 (17 generated)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/1
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/android_arm6...) linux_chromium_chromeos_ozone_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_clobber_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...) linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/20001
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/40001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
Patchset #4 (id:60001) has been deleted
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/80001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/80001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: mac_chromium_compile_dbg_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_comp...) mac_chromium_gn_rel on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_gn_r...) mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/100001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/100001
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
hiroshige@chromium.org changed reviewers: + kinuko@chromium.org
PTAL.
+dcheng for owner review The postTask's in Web{View,Frame}Test are now gone, lgtm for FrameTestHelper.cpp change
hiroshige@chromium.org changed reviewers: + dcheng@chromium.org
dcheng@, PTAL.
https://codereview.chromium.org/1710403003/diff/100001/third_party/WebKit/Sou... File third_party/WebKit/Source/web/tests/WebFrameTest.cpp (left): https://codereview.chromium.org/1710403003/diff/100001/third_party/WebKit/Sou... third_party/WebKit/Source/web/tests/WebFrameTest.cpp:3237: class ReloadWithOverrideURLTask : public WebTaskRunner::Task { I think kinuko@ just removed this so you might have to rebase. https://codereview.chromium.org/1710403003/diff/100001/third_party/WebKit/Sou... File third_party/WebKit/Source/web/tests/WebViewTest.cpp (left): https://codereview.chromium.org/1710403003/diff/100001/third_party/WebKit/Sou... third_party/WebKit/Source/web/tests/WebViewTest.cpp:1348: class DropTask : public WebTaskRunner::Task { This one as well.
The CQ bit was checked by hiroshige@chromium.org to run a CQ dry run
Oh, I see. Rebased.
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/120001
lgtm
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by hiroshige@chromium.org
The patchset sent to the CQ was uploaded after l-g-t-m from kinuko@chromium.org Link to the patchset: https://codereview.chromium.org/1710403003/#ps120001 (title: "Rebase")
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710403003/120001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710403003/120001
Message was sent while issue was closed.
Committed patchset #6 (id:120001)
Message was sent while issue was closed.
Description was changed from ========== Clean up WebTaskRunner::Task subclasses in web/tests/ BUG=478194 ========== to ========== Clean up WebTaskRunner::Task subclasses in web/tests/ BUG=478194 Committed: https://crrev.com/2882d59b5df13afe6e081828a32ce8ee54731b13 Cr-Commit-Position: refs/heads/master@{#376730} ==========
Message was sent while issue was closed.
Patchset 6 (id:??) landed as https://crrev.com/2882d59b5df13afe6e081828a32ce8ee54731b13 Cr-Commit-Position: refs/heads/master@{#376730} |