core/src/fxcodec/codec/fx_codec_fax.cpp - Issue 1710403002: Use safe arithmentic in CFX_BinaryBuf::ExpandBuf.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: core/src/fxcodec/codec/fx_codec_fax.cpp

Issue 1710403002: Use safe arithmentic in CFX_BinaryBuf::ExpandBuf. (Closed) Base URL: https://pdfium.googlesource.com/pdfium.git@master

Patch Set: Unique_ptr, safe arithmetic. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: core/src/fxcodec/codec/fx_codec_fax.cpp

diff --git a/core/src/fxcodec/codec/fx_codec_fax.cpp b/core/src/fxcodec/codec/fx_codec_fax.cpp

index cacbc714561f06f8c42b4f9645446b72d3271b95..36b92f06ffbb3f597a299fb592e74b7d903e39fb 100644

--- a/core/src/fxcodec/codec/fx_codec_fax.cpp

+++ b/core/src/fxcodec/codec/fx_codec_fax.cpp

@@ -799,9 +799,8 @@ void CCodec_FaxEncoder::Encode(uint8_t*& dest_buf, FX_DWORD& dest_size) {

if (dest_bitpos) {

m_DestBuf.AppendByte(last_byte);

}

- dest_buf = m_DestBuf.GetBuffer();

dest_size = m_DestBuf.GetSize();

- m_DestBuf.DetachBuffer();

+ dest_buf = m_DestBuf.DetachBuffer();

}

FX_BOOL CCodec_FaxModule::Encode(const uint8_t* src_buf,

int width,