Use safe arithmentic in CFX_BinaryBuf::ExpandBuf.

Use safe arithmentic in CFX_BinaryBuf::ExpandBuf.

Always call ExpandBuf(), and if it returns, we know the
subsequent calculations won't overflow.

Also use std::unique_ptr, and fix unintentional copies thus
detected by its suppressed copy ctor in fsdk_baseform.cpp

Also Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().

Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.

Also move ByteStringC methods to CFX_ByteTextBuf sub-class.

Also re-order members, may pack tighter on 64-bits.

R=thestig@chromium.org

Committed: https://pdfium.googlesource.com/pdfium/+/78353d5dbc0b0c9b2d6946005439a51efa7d108c

[Tom Sepez, 2016-02-19 18:05:04]

Description was changed from

==========
Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().

Also remove operator= in favor of using << )for similarity
with std::ostream and friends).
==========

to

==========
Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().

Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.
==========

[Tom Sepez, 2016-02-19 18:05:05]

tsepez@chromium.org changed reviewers:
+ thestig@chromium.org

[Tom Sepez, 2016-02-19 18:28:22]

Description was changed from

==========
Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().

Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.
==========

to

==========
Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().

Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.

Also move ByteStringC methods to CFX_ByteTextBuf sub-class.
==========

[Tom Sepez, 2016-02-19 18:33:35]

Description was changed from

==========
Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().

Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.

Also move ByteStringC methods to CFX_ByteTextBuf sub-class.
==========

to

==========
Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().

Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.

Also move ByteStringC methods to CFX_ByteTextBuf sub-class.

Also re-order members, may pack tighter on 64-bits.
==========

[Tom Sepez, 2016-02-19 19:52:44]

Description was changed from

==========
Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().

Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.

Also move ByteStringC methods to CFX_ByteTextBuf sub-class.

Also re-order members, may pack tighter on 64-bits.
==========

to

==========
Use safe arithmentic in CFX_BinaryBuf::ExpandBuf.

Always call ExpandBuf(), and if it returns, we know the
subsequent calculations won't overflow.

Also use std::unique_ptr, and fix unintentional copies thus
detected by its suppressed copy ctor in fsdk_baseform.cpp 

Also Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().

Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.

Also move ByteStringC methods to CFX_ByteTextBuf sub-class.

Also re-order members, may pack tighter on 64-bits.
==========

[Tom Sepez, 2016-02-19 19:54:04]

Lei, for review.  And this started out so simply ...

[Lei Zhang, 2016-02-19 22:05:21]

https://codereview.chromium.org/1710403002/diff/100001/core/src/fpdfapi/fpdf_...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1710403002/diff/100001/core/src/fpdfapi/fpdf_...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:1898:
buf.AppendByte((uint8_t)code);
If you are using CFX_ByteTextBuf, then AppendChar() here and on line 1889 above?

https://codereview.chromium.org/1710403002/diff/100001/core/src/fxcrt/fx_basi...
File core/src/fxcrt/fx_basic_buffer.cpp (left):

https://codereview.chromium.org/1710403002/diff/100001/core/src/fxcrt/fx_basi...
core/src/fxcrt/fx_basic_buffer.cpp:103: if (!m_pBuffer) {
Don't we still need this check?

[Tom Sepez, 2016-02-19 22:17:19]

https://codereview.chromium.org/1710403002/diff/100001/core/src/fpdfapi/fpdf_...
File core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp (right):

https://codereview.chromium.org/1710403002/diff/100001/core/src/fpdfapi/fpdf_...
core/src/fpdfapi/fpdf_parser/fpdf_parser_parser.cpp:1898:
buf.AppendByte((uint8_t)code);
On 2016/02/19 22:05:21, Lei Zhang wrote:
> If you are using CFX_ByteTextBuf, then AppendChar() here and on line 1889
above?

Actually, code is a uint8_t, not a FX_CHAR, so AppendByte() is suitable but lose
the cast.

https://codereview.chromium.org/1710403002/diff/100001/core/src/fxcrt/fx_basi...
File core/src/fxcrt/fx_basic_buffer.cpp (left):

https://codereview.chromium.org/1710403002/diff/100001/core/src/fxcrt/fx_basi...
core/src/fxcrt/fx_basic_buffer.cpp:103: if (!m_pBuffer) {
On 2016/02/19 22:05:21, Lei Zhang wrote:
> Don't we still need this check?

I don't think we can return from ExpandBuf() without a buffer.  Either there's
an AllocSize (and hence a buffer) at line 58, or the alloc succeeds, or the
alloc fails and the FX_alloc and friends abort on the spot at line 65.

[Lei Zhang, 2016-02-19 22:20:18]

lgtm

[Tom Sepez, 2016-02-19 22:23:01]

Description was changed from

==========
Use safe arithmentic in CFX_BinaryBuf::ExpandBuf.

Always call ExpandBuf(), and if it returns, we know the
subsequent calculations won't overflow.

Also use std::unique_ptr, and fix unintentional copies thus
detected by its suppressed copy ctor in fsdk_baseform.cpp 

Also Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().

Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.

Also move ByteStringC methods to CFX_ByteTextBuf sub-class.

Also re-order members, may pack tighter on 64-bits.
==========

to

==========
Use safe arithmentic in CFX_BinaryBuf::ExpandBuf.

Always call ExpandBuf(), and if it returns, we know the
subsequent calculations won't overflow.

Also use std::unique_ptr, and fix unintentional copies thus
detected by its suppressed copy ctor in fsdk_baseform.cpp

Also Remove unused CFX_BinaryBuf::TakeOver(), AppendFill(), CopyData().

Also remove operator= in favor of using <<, for similarity
with std::ostream and friends.

Also move ByteStringC methods to CFX_ByteTextBuf sub-class.

Also re-order members, may pack tighter on 64-bits.

R=thestig@chromium.org

Committed:
https://pdfium.googlesource.com/pdfium/+/78353d5dbc0b0c9b2d6946005439a51efa7d...
==========

[Tom Sepez, 2016-02-19 22:23:03]

Committed patchset #7 (id:120001) manually as
78353d5dbc0b0c9b2d6946005439a51efa7d108c (presubmit successful).