Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(256)

Issue 171032: end-to-end extension API tests (Closed)

Created:
11 years, 4 months ago by Erik does not do reviews
Modified:
9 years, 7 months ago
Reviewers:
Aaron Boodman
CC:
chromium-reviews_googlegroups.com
Visibility:
Public.

Description

An initial pass at structure to do end-to-end extension API tests. I'll work on actually fleshing out some tests in the next CL. (this landed as r23577, the scripts failed to update this entry)

Patch Set 1 #

Patch Set 2 : cleanup #

Patch Set 3 : moved test API to its own module #

Patch Set 4 : minor cleanup #

Total comments: 3

Patch Set 5 : a bit of refactoring and review feedback #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+319 lines, -9 lines) Patch
A chrome/browser/extensions/extension_apitest.h View 1 chunk +47 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_apitest.cc View 1 chunk +74 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_bookmarks_apitest.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/extensions/extension_browsertest.h View 1 2 3 1 chunk +5 lines, -3 lines 0 comments Download
M chrome/browser/extensions/extension_function_dispatcher.cc View 1 2 3 4 4 chunks +12 lines, -3 lines 0 comments Download
A chrome/browser/extensions/extension_test_api.h View 3 4 1 chunk +24 lines, -0 lines 0 comments Download
A chrome/browser/extensions/extension_test_api.cc View 3 4 1 chunk +29 lines, -0 lines 0 comments Download
M chrome/chrome.gyp View 1 2 3 4 2 chunks +7 lines, -2 lines 1 comment Download
M chrome/common/common_resources.grd View 1 chunk +1 line, -1 line 0 comments Download
M chrome/common/extensions/api/extension_api.json View 1 2 3 4 1 chunk +21 lines, -0 lines 0 comments Download
M chrome/common/notification_type.h View 1 chunk +5 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/bookmarks/manifest.json View 1 1 chunk +7 lines, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/bookmarks/test.html View 1 1 chunk +1 line, -0 lines 0 comments Download
A chrome/test/data/extensions/api_test/bookmarks/test.js View 2 3 4 1 chunk +76 lines, -0 lines 1 comment Download

Messages

Total messages: 4 (0 generated)
Erik does not do reviews
11 years, 4 months ago (2009-08-16 23:05:12 UTC) #1
Aaron Boodman
lgtm, cool! http://codereview.chromium.org/171032/diff/23/24 File chrome/browser/extensions/extension_api_browsertest.cc (right): http://codereview.chromium.org/171032/diff/23/24#newcode20 Line 20: static const int kTimeoutMs = 60 ...
11 years, 4 months ago (2009-08-16 23:22:10 UTC) #2
Erik does not do reviews
I did the refactoring you suggested, but also decided to do a bit more while ...
11 years, 4 months ago (2009-08-17 17:03:18 UTC) #3
Aaron Boodman
11 years, 4 months ago (2009-08-17 17:31:02 UTC) #4
LGTM

http://codereview.chromium.org/171032/diff/1027/47
File chrome/chrome.gyp (right):

http://codereview.chromium.org/171032/diff/1027/47#newcode50
Line 50: 'browser/extensions/extension_apitest.cc',
Yes, the name was too long before.

http://codereview.chromium.org/171032/diff/1027/53
File chrome/test/data/extensions/api_test/bookmarks/test.js (right):

http://codereview.chromium.org/171032/diff/1027/53#newcode3
Line 3: function complete() {
It would be nice if this light infrastructure were shared with all tests. I am
not sure how to do it, though.

Powered by Google App Engine
This is Rietveld 408576698