Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(12)

Unified Diff: chrome/browser/ui/views/tabs/tab_unittest.cc

Issue 1710253003: Misc. Tab-related cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Better structure for #ifdefs Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.cc ('k') | ui/gfx/animation/multi_animation.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/views/tabs/tab_unittest.cc
diff --git a/chrome/browser/ui/views/tabs/tab_unittest.cc b/chrome/browser/ui/views/tabs/tab_unittest.cc
index f001038c011f7ef7c028c8ebf8a727a046b0de87..f7cf41704568914f2f0bcfc27646d48731d60d92 100644
--- a/chrome/browser/ui/views/tabs/tab_unittest.cc
+++ b/chrome/browser/ui/views/tabs/tab_unittest.cc
@@ -251,7 +251,7 @@ TEST_F(TabTest, HitTestTopPixel) {
InitWidget(&widget);
FakeTabController tab_controller;
- Tab tab(&tab_controller);
+ Tab tab(&tab_controller, nullptr);
widget.GetContentsView()->AddChildView(&tab);
tab.SetBoundsRect(gfx::Rect(gfx::Point(0, 0), Tab::GetStandardSize()));
@@ -286,7 +286,7 @@ TEST_F(TabTest, LayoutAndVisibilityOfElements) {
InitWidget(&widget);
FakeTabController controller;
- Tab tab(&controller);
+ Tab tab(&controller, nullptr);
widget.GetContentsView()->AddChildView(&tab);
SkBitmap bitmap;
@@ -341,7 +341,7 @@ TEST_F(TabTest, TooltipProvidedByTab) {
InitWidget(&widget);
FakeTabController controller;
- Tab tab(&controller);
+ Tab tab(&controller, nullptr);
widget.GetContentsView()->AddChildView(&tab);
tab.SetBoundsRect(gfx::Rect(Tab::GetStandardSize()));
@@ -391,7 +391,7 @@ TEST_F(TabTest, TooltipProvidedByTab) {
// shouldn't change the insets of the close button.
TEST_F(TabTest, CloseButtonLayout) {
FakeTabController tab_controller;
- Tab tab(&tab_controller);
+ Tab tab(&tab_controller, nullptr);
tab.SetBounds(0, 0, 100, 50);
LayoutTab(&tab);
gfx::Insets close_button_insets = GetCloseButton(tab)->GetInsets();
@@ -413,7 +413,7 @@ TEST_F(TabTest, LayeredThrobber) {
InitWidget(&widget);
FakeTabController tab_controller;
- Tab tab(&tab_controller);
+ Tab tab(&tab_controller, nullptr);
widget.GetContentsView()->AddChildView(&tab);
tab.SetBoundsRect(gfx::Rect(Tab::GetStandardSize()));
@@ -464,7 +464,7 @@ TEST_F(TabTest, LayeredThrobber) {
TEST_F(TabTest, TitleHiddenWhenSmall) {
FakeTabController tab_controller;
- Tab tab(&tab_controller);
+ Tab tab(&tab_controller, nullptr);
tab.SetBounds(0, 0, 100, 50);
EXPECT_GT(GetTitleWidth(tab), 0);
tab.SetBounds(0, 0, 0, 50);
« no previous file with comments | « chrome/browser/ui/views/tabs/tab_strip.cc ('k') | ui/gfx/animation/multi_animation.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698