Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7686)

Unified Diff: chrome/browser/ui/views/tabs/tab_strip.cc

Issue 1710253003: Misc. Tab-related cleanup. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/tabs/tab_strip.cc
diff --git a/chrome/browser/ui/views/tabs/tab_strip.cc b/chrome/browser/ui/views/tabs/tab_strip.cc
index 8fed116ce44a651d67d0e92673f35717083628f6..0887424a097f68024eb3023c156dadb98beb7438 100644
--- a/chrome/browser/ui/views/tabs/tab_strip.cc
+++ b/chrome/browser/ui/views/tabs/tab_strip.cc
@@ -756,7 +756,7 @@ void TabStrip::StopAllHighlighting() {
void TabStrip::AddTabAt(int model_index,
const TabRendererData& data,
bool is_active) {
- Tab* tab = CreateTab();
+ Tab* tab = new Tab(this, animation_container_.get());
AddChildView(tab);
tab->SetData(data);
UpdateTabsClosingMap(model_index, 1);
@@ -1402,9 +1402,9 @@ int TabStrip::GetBackgroundResourceId(bool* custom_image) const {
const bool incognito = controller()->IsIncognito();
const int id = incognito ?
IDR_THEME_TAB_BACKGROUND_INCOGNITO : IDR_THEME_TAB_BACKGROUND;
- const int frame_id = incognito ? IDR_THEME_FRAME_INCOGNITO : IDR_THEME_FRAME;
- *custom_image = tp->HasCustomImage(id) || tp->HasCustomImage(frame_id) ||
- (incognito && tp->HasCustomImage(IDR_THEME_FRAME));
+ *custom_image =
+ tp->HasCustomImage(id) || tp->HasCustomImage(IDR_THEME_FRAME) ||
+ (incognito && tp->HasCustomImage(IDR_THEME_FRAME_INCOGNITO));
return id;
}
@@ -1704,12 +1704,6 @@ void TabStrip::Init() {
}
}
-Tab* TabStrip::CreateTab() {
- Tab* tab = new Tab(this);
- tab->SetAnimationContainer(animation_container_.get());
- return tab;
-}
-
void TabStrip::StartInsertTabAnimation(int model_index) {
PrepareForAnimation();

Powered by Google App Engine
This is Rietveld 408576698