Unbreak --gdbjit for embedders.

Unbreak --gdbjit for embedders.

Embedders don't use d8.cc.  Move gdbjit initialization to api.cc.

BUG=

Committed: https://crrev.com/aea56e0e30ee8a4e401a325c26487e435c0403a1
Cr-Commit-Position: refs/heads/master@{#34180}

[noordhuis, 2016-02-18 22:18:05]

info@bnoordhuis.nl changed reviewers:
+ info@bnoordhuis.nl, yangguo@chromium.org

[noordhuis, 2016-02-18 22:18:05]

PTAL

[Yang, 2016-02-18 22:25:34]

lgtm with suggestion.

https://codereview.chromium.org/1710253002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1710253002/diff/1/src/api.cc#newcode7164
src/api.cc:7164: if (code_event_handler == nullptr && i::FLAG_gdbjit) {
could we have the ifdef around the if-statement?

[noordhuis, 2016-02-19 08:24:43]

https://codereview.chromium.org/1710253002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1710253002/diff/1/src/api.cc#newcode7164
src/api.cc:7164: if (code_event_handler == nullptr && i::FLAG_gdbjit) {
On 2016/02/18 22:25:34, Yang wrote:
> could we have the ifdef around the if-statement?

The idea here was to keep the dead code if !defined(ENABLE_GDB_JIT_INTERFACE) as
small as possible.  I'm happy to change it if that's more in line with the
common style.

[Yang, 2016-02-19 08:29:39]

https://codereview.chromium.org/1710253002/diff/1/src/api.cc
File src/api.cc (right):

https://codereview.chromium.org/1710253002/diff/1/src/api.cc#newcode7164
src/api.cc:7164: if (code_event_handler == nullptr && i::FLAG_gdbjit) {
On 2016/02/19 08:24:43, noordhuis wrote:
> On 2016/02/18 22:25:34, Yang wrote:
> > could we have the ifdef around the if-statement?
> 
> The idea here was to keep the dead code if !defined(ENABLE_GDB_JIT_INTERFACE)
as
> small as possible.  I'm happy to change it if that's more in line with the
> common style.

I still think it's nicer to get rid of the if-statement altogether.

[ofrobots, 2016-02-19 13:29:09]

On 2016/02/19 08:29:40, Yang wrote:

I am guessing this will fix: https://github.com/nodejs/node/issues/2076. Thanks
for fixing.

[noordhuis, 2016-02-21 21:09:31]

On 2016/02/19 08:29:39, Yang wrote:
> I still think it's nicer to get rid of the if-statement altogether.

Done, PTAL.

[Yang, 2016-02-21 21:21:16]

On 2016/02/21 21:09:31, noordhuis wrote:
> On 2016/02/19 08:29:39, Yang wrote:
> > I still think it's nicer to get rid of the if-statement altogether.
> 
> Done, PTAL.

lgtm

[bnoordhuis, 2016-02-21 21:34:49]

The CQ bit was checked by ben@strongloop.com

[commit-bot: I haz the power, 2016-02-21 21:34:54]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1710253002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1710253002/20001

[commit-bot: I haz the power, 2016-02-21 22:02:44]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-21 22:04:16]

Description was changed from

==========
Unbreak --gdbjit for embedders.

Embedders don't use d8.cc.  Move gdbjit initialization to api.cc.

BUG=
==========

to

==========
Unbreak --gdbjit for embedders.

Embedders don't use d8.cc.  Move gdbjit initialization to api.cc.

BUG=

Committed: https://crrev.com/aea56e0e30ee8a4e401a325c26487e435c0403a1
Cr-Commit-Position: refs/heads/master@{#34180}
==========

[commit-bot: I haz the power, 2016-02-21 22:04:17]

Patchset 2 (id:??) landed as
https://crrev.com/aea56e0e30ee8a4e401a325c26487e435c0403a1
Cr-Commit-Position: refs/heads/master@{#34180}