Fix issue 160529 in a nice way

Fix Issue 160529 in a nice way

BUG=none
TEST=none

Resolved in 174027 with same code, but unittested.
Thanks!

[ffmpeg, 2009-08-18 02:53:09]

Please review

BTW: I wanna fix the lint error, how to upload my patch?

[fbarchard, 2009-08-18 22:34:16]

thanks!  This break the unittest, but I'll submit a new version with the
unittest fixed

http://codereview.chromium.org/171023/diff/1/2
File media/filters/ffmpeg_demuxer.cc (left):

http://codereview.chromium.org/171023/diff/1/2#oldcode20
Line 20: if (!clone.get() || av_new_packet(clone.get(), packet->size) < 0) {
removing this breaks the unittest
C:\chrome-svn\src\media\filters\ffmpeg_demuxer_unittest.cc

gmock is rather complicated, so I've fixed it up and will submit this as a new
patch

http://codereview.chromium.org/171023/diff/1/2
File media/filters/ffmpeg_demuxer.cc (right):

http://codereview.chromium.org/171023/diff/1/2#newcode481
Line 481: // In this case, the packet's "destruct" member is NULL, it MUST be
duplicated.
nit more than 80 columns... break comment into 2 lines.

[fbarchard, 2009-08-18 22:55:57]

please see http://codereview.chromium.org/174027
for the unittest

[ffmpeg, 2009-08-19 01:05:25]

http://codereview.chromium.org/174027 is the better place to review this patch

Thanks

http://codereview.chromium.org/171023/diff/1/2
File media/filters/ffmpeg_demuxer.cc (right):

http://codereview.chromium.org/171023/diff/1/2#newcode481
Line 481: // In this case, the packet's "destruct" member is NULL, it MUST be
duplicated.
On 2009/08/18 22:34:16, fbarchard wrote:
> nit more than 80 columns... break comment into 2 lines.
> 

OK, Let's focus on issue: 174027 which is the enhanced version