Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 1710203002: Convert ppapi_unittests to run exclusively on Swarming (Closed)

Created:
4 years, 10 months ago by Nico
Modified:
4 years, 10 months ago
Reviewers:
M-A Ruel
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert ppapi_unittests to run exclusively on Swarming The last time this landed, TSan complained about races on swarming. amistry has since fixed many races, so let's try this again. 0 configs already ran on Swarming 50 used to run locally and were converted: - chromium.chromiumos.json: Linux ChromiumOS Ozone Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (1) - chromium.chromiumos.json: Linux ChromiumOS Tests (dbg)(1) - chromium.fyi.json: CFI Linux - chromium.fyi.json: Chromium Win 10 - chromium.fyi.json: ClangToTLinux tester - chromium.fyi.json: ClangToTLinuxASan tester - chromium.fyi.json: ClangToTLinuxUBSanVptr tester - chromium.fyi.json: ClangToTMac tester - chromium.fyi.json: ClangToTMacASan tester - chromium.fyi.json: ClangToTWin tester - chromium.fyi.json: ClangToTWin(dbg) tester - chromium.fyi.json: ClangToTWin(dll) tester - chromium.fyi.json: ClangToTWin64 tester - chromium.fyi.json: ClangToTWin64(dbg) tester - chromium.fyi.json: ClangToTWin64(dll) tester - chromium.fyi.json: CrWinAsan tester - chromium.fyi.json: CrWinAsan(dll) tester - chromium.fyi.json: CrWinAsanCov tester - chromium.fyi.json: CrWinClang tester - chromium.fyi.json: CrWinClang(dbg) tester - chromium.fyi.json: CrWinClang(shared) tester - chromium.fyi.json: CrWinClang64 tester - chromium.fyi.json: CrWinClang64(dbg) tester - chromium.fyi.json: CrWinClang64(dll) tester - chromium.fyi.json: CrWinClangLLD tester - chromium.fyi.json: Linux Trusty - chromium.fyi.json: Linux Trusty (dbg) - chromium.linux.json: Cast Linux - chromium.linux.json: Linux Tests - chromium.linux.json: Linux Tests (dbg)(1) - chromium.linux.json: Linux Tests (dbg)(1)(32) - chromium.mac.json: Mac10.10 Tests - chromium.mac.json: Mac10.11 Tests - chromium.mac.json: Mac10.6 Tests - chromium.mac.json: Mac10.8 Tests - chromium.mac.json: Mac10.9 Tests - chromium.mac.json: Mac10.9 Tests (dbg) - chromium.memory.fyi.json: Linux ChromeOS MSan Tests - chromium.memory.fyi.json: Linux MSan Tests - chromium.memory.fyi.json: Linux TSan Tests - chromium.memory.json: Linux ASan LSan Tests (1) - chromium.memory.json: Linux Chromium OS ASan LSan Tests (1) - chromium.memory.json: Mac ASan 64 Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (1) - chromium.webkit.json: Linux ChromiumOS Tests (dbg)(1) - chromium.webkit.json: WebKit Linux Oilpan - chromium.win.json: Win 7 Tests x64 (1) - chromium.win.json: Win7 Tests (1) - chromium.win.json: Win7 Tests (dbg)(1) Ran: ./manage.py --convert ppapi_unittests BUG=98637 Committed: https://crrev.com/7cde2230e65af50dcf227b4218463d1c274d1bec Cr-Commit-Position: refs/heads/master@{#376351}

Patch Set 1 #

Patch Set 2 : gn #

Unified diffs Side-by-side diffs Delta from patch set Stats (+151 lines, -1 line) Patch
M testing/buildbot/chromium.chromiumos.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.fyi.json View 25 chunks +75 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.linux.json View 4 chunks +12 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.mac.json View 6 chunks +18 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.memory.fyi.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.webkit.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/chromium.win.json View 3 chunks +9 lines, -0 lines 0 comments Download
M testing/buildbot/gn_isolate_map.pyl View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (5 generated)
Nico
(the red bots are unrelated)
4 years, 10 months ago (2016-02-18 21:47:19 UTC) #2
M-A Ruel
thank you so much for doing this. lgtm
4 years, 10 months ago (2016-02-18 22:02:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710203002/20001
4 years, 10 months ago (2016-02-18 22:10:52 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_compile_dbg_ng on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_compile_dbg_ng/builds/52146)
4 years, 10 months ago (2016-02-18 22:46:04 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1710203002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1710203002/20001
4 years, 10 months ago (2016-02-19 02:16:19 UTC) #9
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-19 02:41:56 UTC) #10
commit-bot: I haz the power
4 years, 10 months ago (2016-02-19 02:42:52 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/7cde2230e65af50dcf227b4218463d1c274d1bec
Cr-Commit-Position: refs/heads/master@{#376351}

Powered by Google App Engine
This is Rietveld 408576698