Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Unified Diff: net/quic/quic_connection.cc

Issue 1710173002: relnote: Deprecate FLAGS_quic_retransmit_via_onserializedpacket. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | net/quic/quic_flags.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: net/quic/quic_connection.cc
diff --git a/net/quic/quic_connection.cc b/net/quic/quic_connection.cc
index e796745e06e137cfc662f8945c95a791ec5cac67..c7aa9540bb14b3da2b89c410f86db5d9ab42015b 100644
--- a/net/quic/quic_connection.cc
+++ b/net/quic/quic_connection.cc
@@ -1511,27 +1511,7 @@ void QuicConnection::WritePendingRetransmissions() {
// does not require the creator to be flushed.
packet_generator_.FlushAllQueuedFrames();
char buffer[kMaxPacketSize];
- SerializedPacket serialized_packet =
- packet_generator_.ReserializeAllFrames(pending, buffer, kMaxPacketSize);
- if (FLAGS_quic_retransmit_via_onserializedpacket) {
- DCHECK(serialized_packet.encrypted_buffer == nullptr);
- continue;
- }
- if (serialized_packet.encrypted_buffer == nullptr) {
- // We failed to serialize the packet, so close the connection.
- // CloseConnection does not send close packet, so no infinite loop here.
- // TODO(ianswett): This is actually an internal error, not an encryption
- // failure.
- CloseConnection(QUIC_ENCRYPTION_FAILURE,
- ConnectionCloseSource::FROM_SELF);
- return;
- }
-
- DVLOG(1) << ENDPOINT << "Retransmitting " << pending.packet_number << " as "
- << serialized_packet.packet_number;
- serialized_packet.original_packet_number = pending.packet_number;
- serialized_packet.transmission_type = pending.transmission_type;
- SendOrQueuePacket(&serialized_packet);
+ packet_generator_.ReserializeAllFrames(pending, buffer, kMaxPacketSize);
}
}
« no previous file with comments | « no previous file | net/quic/quic_flags.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698