Issue 1710163002: Always set the previous token in AstCloner.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1710163002: Always set the previous token in AstCloner. (Closed)

Created:
4 years, 10 months ago by scheglov

Modified:
4 years, 10 months ago

Reviewers:
Brian Wilkerson

CC:
reviews_dartlang.org

Base URL:
git@github.com:dart-lang/sdk.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

More Reviews

Description

Always set the previous token in AstCloner. R=brianwilkerson@google.com BUG= Committed: https://github.com/dart-lang/sdk/commit/5db3ae73bfc078fbe3c68a9e525b3f931ef8b8d4

Patch Set 1 #

Total comments: 1

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+6 lines, -2 lines)			Patch
	M	pkg/analyzer/lib/src/dart/ast/utilities.dart	View		2 chunks	+2 lines, -2 lines	1 comment	Download
	M	pkg/analyzer/test/generated/utilities_test.dart	View		1 chunk	+4 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Brian Wilkerson

LGTM https://codereview.chromium.org/1710163002/diff/1/pkg/analyzer/lib/src/dart/ast/utilities.dart File pkg/analyzer/lib/src/dart/ast/utilities.dart (right): https://codereview.chromium.org/1710163002/diff/1/pkg/analyzer/lib/src/dart/ast/utilities.dart#newcode45 pkg/analyzer/lib/src/dart/ast/utilities.dart:45: Token _lastCloned = new Token(TokenType.EOF, -1); The EOF ...

4 years, 10 months ago (2016-02-18 21:00:34 UTC) #2

scheglov

4 years, 10 months ago (2016-02-18 21:40:25 UTC) #4

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
5db3ae73bfc078fbe3c68a9e525b3f931ef8b8d4 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages