Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(533)

Unified Diff: tools/perf/metrics/timeline_unittest.py

Issue 171013006: Telemetry: Use mimimum tracing for timeline benchmarks. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove @property. Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tools/perf/metrics/timeline.py ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/metrics/timeline_unittest.py
diff --git a/tools/perf/metrics/timeline_unittest.py b/tools/perf/metrics/timeline_unittest.py
index ebc72eb1d8da4e2b22b0a38ce4b51badc7d59c89..d12fd20064a2dd2689d8be044eb9921f8043b9ea 100644
--- a/tools/perf/metrics/timeline_unittest.py
+++ b/tools/perf/metrics/timeline_unittest.py
@@ -109,7 +109,6 @@ class ThreadTimesTimelineMetricUnittest(unittest.TestCase):
# Test that all result thread categories exist
for name in timeline.TimelineThreadCategories.values():
- results.GetPageSpecificValueNamed(timeline.ThreadTimeResultName(name))
results.GetPageSpecificValueNamed(timeline.ThreadCpuTimeResultName(name))
def testBasic(self):
@@ -143,7 +142,7 @@ class ThreadTimesTimelineMetricUnittest(unittest.TestCase):
# Test a couple specific results.
assert_results = {
- timeline.ThreadTimeResultName('renderer_main') : 10,
+ timeline.ThreadCpuTimeResultName('renderer_main') : 9.75,
timeline.ThreadDetailResultName('renderer_main','cat1') : 9.5,
timeline.ThreadDetailResultName('renderer_main','cat2') : 0.5,
timeline.ThreadDetailResultName('renderer_main','idle') : 0
@@ -180,7 +179,6 @@ class ThreadTimesTimelineMetricUnittest(unittest.TestCase):
# Test a couple specific results.
assert_results = {
- timeline.ThreadTimeResultName('renderer_main') : 19,
timeline.ThreadCpuTimeResultName('renderer_main') : 9.0,
}
for name, value in assert_results.iteritems():
« no previous file with comments | « tools/perf/metrics/timeline.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698