Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(18)

Issue 1710123002: Update yasm to the same version currently used by Chromium. (Closed)

Created:
4 years, 10 months ago by viettrungluu
Modified:
4 years, 10 months ago
Reviewers:
jamesr
CC:
mojo-reviews_chromium.org
Base URL:
https://github.com/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Update yasm to the same version currently used by Chromium. * yasm as in Chromium at 5def0de596a472b50c5bfb99ec218c36241e4631. * I checked that yasm and ffmpeg still appear to build. * Remove DONT_EMBED_BUILD_METADATA (the main reason for updating yasm). * Remove yasm's OWNERS file. * Remove an (apparently) unnecessary entry in .gitignore. R=jamesr@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/4986f094807d106a9076b17353aaadf144abf2a0

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+53 lines, -21 lines) Patch
M .gitignore View 1 chunk +0 lines, -1 line 0 comments Download
M DEPS View 1 chunk +1 line, -1 line 0 comments Download
M build/config/BUILD.gn View 1 chunk +0 lines, -3 lines 0 comments Download
M third_party/yasm/BUILD.gn View 9 chunks +49 lines, -8 lines 0 comments Download
M third_party/yasm/CHROMIUM.diff View 2 chunks +2 lines, -6 lines 0 comments Download
D third_party/yasm/OWNERS View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/yasm/README.chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 4 (1 generated)
viettrungluu
4 years, 10 months ago (2016-02-18 19:13:11 UTC) #1
jamesr
lgtm
4 years, 10 months ago (2016-02-18 19:20:02 UTC) #2
viettrungluu
4 years, 10 months ago (2016-02-18 19:23:16 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
4986f094807d106a9076b17353aaadf144abf2a0 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698