Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(402)

Unified Diff: remoting/protocol/libjingle_transport_factory.h

Issue 17101034: Add static Create method to LibjingleTransportFactory (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fixed style violations Created 7 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/libjingle_transport_factory.h
diff --git a/remoting/protocol/libjingle_transport_factory.h b/remoting/protocol/libjingle_transport_factory.h
index bb54bd4e7f951bdb8bbafd971c5f82c0486ede7e..bece1ff2fe5929b00323dee9fcdacceaa84b970d 100644
--- a/remoting/protocol/libjingle_transport_factory.h
+++ b/remoting/protocol/libjingle_transport_factory.h
@@ -12,16 +12,30 @@ class HttpPortAllocatorBase;
class PortAllocator;
} // namespace cricket
+namespace net {
+class URLRequestContextGetter;
+} // namespace net
+
namespace talk_base {
class NetworkManager;
class PacketSocketFactory;
} // namespace talk_base
namespace remoting {
+
+class NetworkSettings;
+
namespace protocol {
class LibjingleTransportFactory : public TransportFactory {
public:
+ // Creates an instance of the class using ChromiumSocketFactory.
Sergey Ulanov 2013/06/21 01:21:57 nit: actually it should be ChromiumPortAllocator.
+ // Performs network operations, so must be called from IO thread.
Sergey Ulanov 2013/06/21 01:21:57 nit: remove "Performs network operations" - it's n
+ static scoped_ptr<LibjingleTransportFactory> Create(
+ const NetworkSettings& network_settings,
+ const scoped_refptr<net::URLRequestContextGetter>&
+ url_request_context_getter);
+
// Need to use cricket::HttpPortAllocatorBase pointer for the
// |port_allocator|, so that it is possible to configure
// |port_allocator| with STUN/Relay addresses.

Powered by Google App Engine
This is Rietveld 408576698