Add static Create method to LibjingleTransportFactory

remoting/host/session_manager_factory.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.

[Sergey Ulanov, 2013/06/21 00:48:13]

It's strange that rietveld shows this file as deleted (D in the list of files),
but here it looks like you are just changing it. CQ will probably be able to
land it anyway, so this is just FYI if there are any problems when landing it.

 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/session_manager_factory.h"
 
-#include "net/url_request/url_request_context_getter.h"
-#include "remoting/host/host_port_allocator.h"
-#include "remoting/host/network_settings.h"
+#include "remoting/jingle_glue/chromium_port_allocator.h"
+#include "remoting/jingle_glue/network_settings.h"
+#include "remoting/protocol/jingle_session_manager.h"
 #include "remoting/protocol/libjingle_transport_factory.h"
-#include "remoting/protocol/jingle_session_manager.h"
+#include "remoting/protocol/session_manager.h"
 
 namespace remoting {
 
 scoped_ptr<protocol::SessionManager> CreateHostSessionManager(
     const NetworkSettings& network_settings,
     const scoped_refptr<net::URLRequestContextGetter>&
         url_request_context_getter) {
-  // Use Chrome's network stack to allocate ports for peer-to-peer channels.
-  scoped_ptr<HostPortAllocator> port_allocator(
-      HostPortAllocator::Create(url_request_context_getter,
-                                network_settings));
-
-  bool incoming_only = network_settings.nat_traversal_mode ==
-      NetworkSettings::NAT_TRAVERSAL_DISABLED;
-
-  // Use libjingle for negotiation of peer-to-peer channels over
-  // HostPortAllocator allocated ports.
   scoped_ptr<protocol::TransportFactory> transport_factory(
-      new protocol::LibjingleTransportFactory(
-          port_allocator.PassAs<cricket::HttpPortAllocatorBase>(),
-          incoming_only));
+      protocol::LibjingleTransportFactory::Create(network_settings,
+                                        url_request_context_getter));

[Sergey Ulanov, 2013/06/21 00:48:13]

incorrect indentation.
http://google-styleguide.googlecode.com/svn/trunk/cppguide.xml?showone=Functi...

 
   // Use the Jingle protocol for channel-negotiation signalling between
   // peer TransportFactories.
   bool fetch_stun_relay_info = network_settings.nat_traversal_mode ==
       NetworkSettings::NAT_TRAVERSAL_ENABLED;
 
   scoped_ptr<protocol::JingleSessionManager> session_manager(
       new protocol::JingleSessionManager(
           transport_factory.Pass(), fetch_stun_relay_info));
   return session_manager.PassAs<protocol::SessionManager>();
 }
 
 } // namespace remoting